External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs

Browse Source 
Post-audit sweep over the 135 audit-fix commits since 19a474d3:

1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token
   from docstring openings across 211 blocks / ~626 lines. The CEO flagged
   these twice: audit-issue IDs in code confuse future devs/agents. The
   descriptive text is preserved; only the Fxxx token is removed (and bloated
   narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant).
2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines).
3. Added missing behavior-change docs for the audit-fix batch: prompts/roles
   (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets,
   agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience,
   conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm,
   main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation;
   megatask; task-claiming workflows).

Comment/docstring/prose ONLY — zero code-line edits (verified: the diff
contains no def/class/return/if/for/await/assignment/call lines). Gates green:
ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures
are the pre-existing sync_branch tracing-decision gap (B1, 250be5c2) — not
sweep-caused and tracked separately.
This commit is contained in:
Renn F
2026-06-29 01:25:40 +02:00
parent fb850e8235
commit 3441e37120
131 changed files with 842 additions and 1391 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/services/test_notification.py
+6 -6
View File
@@ -325,7 +325,7 @@ async def test_create_notification_skips_when_no_resolvable_recipients(
# ---------------------------------------------------------------------------
# F009 — requires_ack must follow ACK_REQUIRED_BY_TYPE, not the True default
# requires_ack must follow ACK_REQUIRED_BY_TYPE, not the True default
# ---------------------------------------------------------------------------
@@ -333,8 +333,8 @@ async def test_create_notification_skips_when_no_resolvable_recipients(
async def test_informational_notification_does_not_require_ack(
svc: NotificationService,
) -> None:
"""F009: REVIEW_REQUEST / DOCUMENTATION_REQUEST / A2A_REQUEST are
informational (pickup proves receipt) — requires_ack must be False, not the
"""REVIEW_REQUEST / DOCUMENTATION_REQUEST / A2A_REQUEST are informational
(pickup proves receipt) — requires_ack must be False, not the
NotificationTable True default. A False type forced to True inflates the
recipient's unacked set and soft-blocks i_am_idle → respawn churn."""
aid = uuid4()
@@ -368,7 +368,7 @@ async def test_informational_notification_does_not_require_ack(
async def test_action_required_notification_still_requires_ack(
svc: NotificationService,
) -> None:
"""F009: BLOCKER_ESCALATION / APPROVAL / ALERT are action-required —
"""BLOCKER_ESCALATION / APPROVAL / ALERT are action-required —
requires_ack stays True (ACK_REQUIRED_BY_TYPE maps them True)."""
aid = uuid4()
db = _FakeDb(agent_uuid=aid)
@@ -389,8 +389,8 @@ async def test_action_required_notification_still_requires_ack(
async def test_create_notification_requires_ack_derives_from_type(
svc: NotificationService,
) -> None:
"""F009: a raw _create_notification call derives requires_ack from the type
via ACK_REQUIRED_BY_TYPE (KNOWLEDGE_SHARE → False)."""
"""A raw _create_notification call derives requires_ack from the type via
ACK_REQUIRED_BY_TYPE (KNOWLEDGE_SHARE → False)."""
aid = uuid4()
db = _FakeDb(agent_uuid=aid)
with _patch_db_context(db):