External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs

Browse Source 
Post-audit sweep over the 135 audit-fix commits since 19a474d3:

1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token
   from docstring openings across 211 blocks / ~626 lines. The CEO flagged
   these twice: audit-issue IDs in code confuse future devs/agents. The
   descriptive text is preserved; only the Fxxx token is removed (and bloated
   narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant).
2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines).
3. Added missing behavior-change docs for the audit-fix batch: prompts/roles
   (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets,
   agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience,
   conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm,
   main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation;
   megatask; task-claiming workflows).

Comment/docstring/prose ONLY — zero code-line edits (verified: the diff
contains no def/class/return/if/for/await/assignment/call lines). Gates green:
ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures
are the pre-existing sync_branch tracing-decision gap (B1, 250be5c2) — not
sweep-caused and tracked separately.
This commit is contained in:
Renn F
2026-06-29 01:25:40 +02:00
parent fb850e8235
commit 3441e37120
131 changed files with 842 additions and 1391 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/services/test_git_merge_method_fallback.py
+5 -9
View File
@@ -167,13 +167,9 @@ async def test_merge_does_not_retry_when_method_allowed(
async def test_merge_already_merged_pr_is_idempotent_success(
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""F049: the CEO ``merge_pull_request`` path must treat an already-merged PR
as idempotent success, not raise GitError — mirroring ``_merge_with_retry``
(the agent-facing path). A merge PUT on an already-merged PR returns the
same 405 as a genuine "not mergeable" refusal, so without disambiguation a
CEO retry (double-click, or a re-merge after a network blip where the first
PUT actually landed) raises GitError instead of no-opping — surfacing a
spurious failure on the very master-merge path the CEO owns.
"""The CEO ``merge_pull_request`` path treats an already-merged PR as
idempotent success (not GitError) — a merge PUT on an already-merged PR
returns the same 405 as a genuine refusal, so they must be disambiguated.
"""
svc = _git_service()
@@ -216,8 +212,8 @@ async def test_merge_already_merged_pr_is_idempotent_success(
async def test_merge_raises_when_not_merged_and_refused(
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""F049: a genuine merge refusal (not mergeable, NOT already-merged) still
raises GitError — the idempotency guard must not mask a real failure."""
"""A genuine merge refusal (not mergeable, NOT already-merged) still raises
GitError — the idempotency guard must not mask a real failure."""
svc = _git_service()
monkeypatch.setattr(