mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs
Post-audit sweep over the 135 audit-fix commits since19a474d3: 1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token from docstring openings across 211 blocks / ~626 lines. The CEO flagged these twice: audit-issue IDs in code confuse future devs/agents. The descriptive text is preserved; only the Fxxx token is removed (and bloated narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant). 2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines). 3. Added missing behavior-change docs for the audit-fix batch: prompts/roles (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets, agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience, conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm, main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation; megatask; task-claiming workflows). Comment/docstring/prose ONLY — zero code-line edits (verified: the diff contains no def/class/return/if/for/await/assignment/call lines). Gates green: ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures are the pre-existing sync_branch tracing-decision gap (B1,250be5c2) — not sweep-caused and tracked separately.
This commit is contained in:
@@ -1,14 +1,6 @@
|
||||
"""F019 — a git mutation op killed by ``_run_git``'s timeout orphans lock files.
|
||||
|
||||
``subprocess.run(..., timeout=...)`` sends SIGKILL on timeout. A git mutation
|
||||
(commit / merge --ff-only / rebase / reset --hard / add) killed mid-write
|
||||
orphaned ``.git/index.lock`` (+ ``HEAD.lock`` / ``refs/**.lock`` /
|
||||
``packed-refs.lock``), wedging the workspace for every subsequent op —
|
||||
including the next fresh-claim ``reset --hard`` — with
|
||||
"Another git process seems to be running in this repository". The fix
|
||||
best-effort removes stale ``.git/**/*.lock`` files in the timeout branch
|
||||
before re-raising, since the git process is dead by the time the timeout
|
||||
fires.
|
||||
"""A git mutation op killed by ``_run_git``'s timeout best-effort removes
|
||||
orphaned ``.git/**/*.lock`` files before re-raising — the SIGKILL'd git
|
||||
process can't clean up itself, and the locks wedge every subsequent op.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
Reference in New Issue
Block a user