mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs
Post-audit sweep over the 135 audit-fix commits since19a474d3: 1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token from docstring openings across 211 blocks / ~626 lines. The CEO flagged these twice: audit-issue IDs in code confuse future devs/agents. The descriptive text is preserved; only the Fxxx token is removed (and bloated narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant). 2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines). 3. Added missing behavior-change docs for the audit-fix batch: prompts/roles (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets, agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience, conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm, main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation; megatask; task-claiming workflows). Comment/docstring/prose ONLY — zero code-line edits (verified: the diff contains no def/class/return/if/for/await/assignment/call lines). Gates green: ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures are the pre-existing sync_branch tracing-decision gap (B1,250be5c2) — not sweep-caused and tracked separately.
This commit is contained in:
@@ -1,15 +1,6 @@
|
||||
"""F051: open_conventions_pr must not operate on a dirty working tree.
|
||||
|
||||
``open_conventions_pr`` cuts its scaffold branch in an agent's clone (or the
|
||||
project's shared ``workspace_path``). It does ``checkout <base>`` with
|
||||
``check=False`` and then ``checkout -B <scaffold>``. On a dirty tree the
|
||||
``checkout <base>`` either no-ops (already on base) or is refused and silently
|
||||
swallowed; ``checkout -B <scaffold>`` then carries the agent's uncommitted
|
||||
work onto the scaffold branch, and the ``commit`` sweeps it into the
|
||||
project-level conventions commit — the agent's in-progress change is gone
|
||||
from their working tree and rides a PR they never intended. Refuse a dirty
|
||||
tree up front (return None, no checkout) so an active workspace is never
|
||||
touched.
|
||||
"""``open_conventions_pr`` refuses a dirty working tree up front (returns
|
||||
None, no checkout) so an active agent workspace is never swept into a
|
||||
project-level conventions commit.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
Reference in New Issue
Block a user