mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs
Post-audit sweep over the 135 audit-fix commits since19a474d3: 1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token from docstring openings across 211 blocks / ~626 lines. The CEO flagged these twice: audit-issue IDs in code confuse future devs/agents. The descriptive text is preserved; only the Fxxx token is removed (and bloated narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant). 2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines). 3. Added missing behavior-change docs for the audit-fix batch: prompts/roles (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets, agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience, conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm, main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation; megatask; task-claiming workflows). Comment/docstring/prose ONLY — zero code-line edits (verified: the diff contains no def/class/return/if/for/await/assignment/call lines). Gates green: ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures are the pre-existing sync_branch tracing-decision gap (B1,250be5c2) — not sweep-caused and tracked separately.
This commit is contained in:
@@ -83,13 +83,9 @@ def test_partition_drops_terminal_and_missing_rows() -> None:
|
||||
|
||||
|
||||
def test_partition_restamps_last_check_to_now_to_avoid_stale_tracing_gap() -> None:
|
||||
# F034: a persisted last_check from BEFORE the restart would make the first
|
||||
# post-restart ``_pm_made_rule_following_retry`` audit lookup
|
||||
# (``since = record.get("last_check")``) match a PRE-restart tracing_gap
|
||||
# row, falsely resetting the breaker on the very first post-restart spawn —
|
||||
# exactly when a fresh strike count should be evaluating current state.
|
||||
# Restore must re-stamp last_check to the restore time so only post-restart
|
||||
# tracing gaps can reset the counter.
|
||||
# Restore must re-stamp last_check to the restore time so a pre-restart
|
||||
# tracing_gap row can't falsely reset the breaker on the first post-restart
|
||||
# spawn.
|
||||
tid = uuid4()
|
||||
stale_check = datetime(2026, 6, 20, tzinfo=UTC)
|
||||
rows = [_row(tid, last_check=stale_check)]
|
||||
@@ -380,7 +376,7 @@ async def test_restart_midloop_continues_identically_to_no_restart() -> None:
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------- #
|
||||
# F096 — fire-and-forget persist commit ordering
|
||||
# fire-and-forget persist commit ordering
|
||||
# --------------------------------------------------------------------------- #
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user