mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs
Post-audit sweep over the 135 audit-fix commits since19a474d3: 1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token from docstring openings across 211 blocks / ~626 lines. The CEO flagged these twice: audit-issue IDs in code confuse future devs/agents. The descriptive text is preserved; only the Fxxx token is removed (and bloated narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant). 2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines). 3. Added missing behavior-change docs for the audit-fix batch: prompts/roles (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets, agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience, conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm, main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation; megatask; task-claiming workflows). Comment/docstring/prose ONLY — zero code-line edits (verified: the diff contains no def/class/return/if/for/await/assignment/call lines). Gates green: ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures are the pre-existing sync_branch tracing-decision gap (B1,250be5c2) — not sweep-caused and tracked separately.
This commit is contained in:
@@ -1,13 +1,8 @@
|
||||
"""F098: a re-park during probe-success resume must not orphan the agent.
|
||||
|
||||
``resolve_wait`` deletes the waiting record (in-memory + durable) and then calls
|
||||
``spawn_agent`` to respawn the parked agent. If the provider re-parks in the
|
||||
window between the probe-success clear and the spawn (the rate limit lifts then
|
||||
immediately re-limits, or a second provider limit lands), ``spawn_agent`` bails
|
||||
with an OFFLINE instance — the F095 parked-provider short-circuit. The old order
|
||||
deleted the record BEFORE the spawn, so a bail orphaned the agent: no record
|
||||
means the probe-resume loop can never revive it and the spawn gate bails every
|
||||
tick. The record must stay until a container actually launches.
|
||||
"""A re-park during probe-success resume must not orphan the agent. The waiting
|
||||
record must stay until ``spawn_agent`` actually launches a container — deleting
|
||||
it before the spawn lets a provider re-park (``spawn_agent`` bails OFFLINE on
|
||||
the parked-provider short-circuit) leave the agent with no record for the
|
||||
probe-resume loop to revive.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
Reference in New Issue
Block a user