External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs

Browse Source 
Post-audit sweep over the 135 audit-fix commits since 19a474d3:

1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token
   from docstring openings across 211 blocks / ~626 lines. The CEO flagged
   these twice: audit-issue IDs in code confuse future devs/agents. The
   descriptive text is preserved; only the Fxxx token is removed (and bloated
   narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant).
2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines).
3. Added missing behavior-change docs for the audit-fix batch: prompts/roles
   (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets,
   agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience,
   conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm,
   main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation;
   megatask; task-claiming workflows).

Comment/docstring/prose ONLY — zero code-line edits (verified: the diff
contains no def/class/return/if/for/await/assignment/call lines). Gates green:
ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures
are the pre-existing sync_branch tracing-decision gap (B1, 250be5c2) — not
sweep-caused and tracked separately.
This commit is contained in:
Renn F
2026-06-29 01:25:40 +02:00
parent fb850e8235
commit 3441e37120
131 changed files with 842 additions and 1391 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/runtime/test_orchestrator_write_hooks.py
+6 -8
View File
@@ -568,10 +568,9 @@ def _stop_agent_patches(orch: AgentOrchestrator) -> Any:
async def test_stop_agent_releases_claim_when_release_claim_true() -> None:
"""F120: stop_agent(release_claim=True) hands the agent's claimed task back
to the pool immediately. A SIGTERM/budget-kill mid-verb otherwise leaves
the task CLAIMED/IN_PROGRESS with no running agent for up to
stale_claim_reap_seconds (the reaper's heartbeat TTL)."""
"""stop_agent(release_claim=True) releases the agent's claimed task to the
pool immediately, so a mid-verb SIGTERM/budget-kill doesn't strand the task
CLAIMED/IN_PROGRESS until the reaper's heartbeat TTL expires."""
orch = _make_orchestrator()
instance = _make_instance(_AGENT_ID)
instance.current_task_id = str(uuid4())
@@ -631,10 +630,9 @@ async def test_stop_agent_does_not_release_claim_by_default() -> None:
async def test_stop_agent_skips_release_for_provider_parked_agent() -> None:
"""F120: a provider-parked agent (rate_limit_lifted WaitingRecord) must NOT
have its claim released even when release_claim=True. The probe-resume loop
owns its recovery and the claim must survive so probe-success revives the
SAME agent on the SAME task — reaping would let another agent claim it."""
"""A provider-parked agent (rate_limit_lifted WaitingRecord) must NOT have
its claim released even when release_claim=True — the probe-resume loop
revives the SAME agent on the SAME task, so reaping would lose the claim."""
orch = _make_orchestrator()
instance = _make_instance(_AGENT_ID)
instance.current_task_id = str(uuid4())