mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs
Post-audit sweep over the 135 audit-fix commits since19a474d3: 1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token from docstring openings across 211 blocks / ~626 lines. The CEO flagged these twice: audit-issue IDs in code confuse future devs/agents. The descriptive text is preserved; only the Fxxx token is removed (and bloated narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant). 2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines). 3. Added missing behavior-change docs for the audit-fix batch: prompts/roles (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets, agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience, conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm, main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation; megatask; task-claiming workflows). Comment/docstring/prose ONLY — zero code-line edits (verified: the diff contains no def/class/return/if/for/await/assignment/call lines). Gates green: ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures are the pre-existing sync_branch tracing-decision gap (B1,250be5c2) — not sweep-caused and tracked separately.
This commit is contained in:
@@ -37,8 +37,8 @@ def _make_minimal_orchestrator() -> AgentOrchestrator:
|
||||
# (F071); without this the post-docker-run guard would AttributeError on
|
||||
# the constructor-skipped instance.
|
||||
orch._running = True
|
||||
# F093: concurrent intake starts serialize on this lock; the constructor
|
||||
# (skipped here) initializes it.
|
||||
# Concurrent intake starts serialize on this lock; the constructor (skipped
|
||||
# here) initializes it.
|
||||
orch._intake_spawn_lock = asyncio.Lock()
|
||||
return orch
|
||||
|
||||
@@ -572,11 +572,9 @@ class TestDeliverWhenReady:
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# F071 — non-blocking intake spawn must not orphan a container if shutdown
|
||||
# arrives between ``docker run`` and the _instances registration. The guarded
|
||||
# wrapper runs concurrently with stop(); without a post-docker-run shutdown
|
||||
# check, the just-started container is never recorded in _instances (which
|
||||
# stop() already iterated) so nothing tears it down — a leaked container.
|
||||
# Non-blocking intake spawn must not orphan a container if shutdown arrives
|
||||
# between ``docker run`` and _instances registration: without a post-docker-run
|
||||
# shutdown check the just-started container is never recorded so leaks.
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user