mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs
Post-audit sweep over the 135 audit-fix commits since19a474d3: 1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token from docstring openings across 211 blocks / ~626 lines. The CEO flagged these twice: audit-issue IDs in code confuse future devs/agents. The descriptive text is preserved; only the Fxxx token is removed (and bloated narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant). 2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines). 3. Added missing behavior-change docs for the audit-fix batch: prompts/roles (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets, agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience, conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm, main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation; megatask; task-claiming workflows). Comment/docstring/prose ONLY — zero code-line edits (verified: the diff contains no def/class/return/if/for/await/assignment/call lines). Gates green: ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures are the pre-existing sync_branch tracing-decision gap (B1,250be5c2) — not sweep-caused and tracked separately.
This commit is contained in:
@@ -196,16 +196,9 @@ def test_in_progress_task_with_no_agent_returns_assignee() -> None:
|
||||
|
||||
|
||||
def test_claimed_task_with_unknown_assignee_returns_slug_for_release() -> None:
|
||||
# F032: a claimed/in_progress task whose assignee is a stale/unknown UUID
|
||||
# (no seeded agent) must reach the release-to-pending path. The human-only
|
||||
# guard (role_for_slug_or_none) returns None for an unknown slug, and
|
||||
# ``None in (CEO, PROMPTER, SECRETARY)`` is False — so it does NOT
|
||||
# short-circuit, the slug falls through the grace window, and the resolver
|
||||
# returns the unknown slug. _dispatch_claimed_without_agent then sees
|
||||
# get_agent_role(slug) == "unknown" and releases the claim to pending for
|
||||
# a role-matched reclaim. Before F031's role_for_slug_or_none fix the guard
|
||||
# raised KeyError on the unknown slug, crashing the whole tick before the
|
||||
# release path could run.
|
||||
# A claimed/in_progress task whose assignee is a stale/unknown UUID (no
|
||||
# seeded agent) must reach the release-to-pending path: the human-only guard
|
||||
# returns None for unknown slugs, so the slug falls through and is released.
|
||||
orch = _orch()
|
||||
unknown_uuid = str(uuid4())
|
||||
task: dict[str, Any] = {
|
||||
|
||||
Reference in New Issue
Block a user