External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs

Browse Source 
Post-audit sweep over the 135 audit-fix commits since 19a474d3:

1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token
   from docstring openings across 211 blocks / ~626 lines. The CEO flagged
   these twice: audit-issue IDs in code confuse future devs/agents. The
   descriptive text is preserved; only the Fxxx token is removed (and bloated
   narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant).
2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines).
3. Added missing behavior-change docs for the audit-fix batch: prompts/roles
   (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets,
   agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience,
   conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm,
   main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation;
   megatask; task-claiming workflows).

Comment/docstring/prose ONLY — zero code-line edits (verified: the diff
contains no def/class/return/if/for/await/assignment/call lines). Gates green:
ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures
are the pre-existing sync_branch tracing-decision gap (B1, 250be5c2) — not
sweep-caused and tracked separately.
This commit is contained in:
Renn F
2026-06-29 01:25:40 +02:00
parent fb850e8235
commit 3441e37120
131 changed files with 842 additions and 1391 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/gateway/test_toolchain_guard.py
+5 -8
View File
@@ -99,11 +99,9 @@ async def test_guard_silent_when_no_marker(monkeypatch: pytest.MonkeyPatch) -> N
async def test_guard_reviewer_remediation_uses_pr_fail_not_i_am_blocked(
monkeypatch: pytest.MonkeyPatch,
) -> None:
# F044: the pr_pass gate runs this guard on the REVIEWER's workspace. A PR
# reviewer has no i_am_blocked verb, so the dev-path remediation ("call
# i_am_blocked(reason='toolchain')") sends them to a verb they cannot call.
# The reviewer's reject lever is pr_fail — the remediation must point there
# so the PR goes back to needs_revision for the dev to fix the environment.
# pr_pass runs this guard on the REVIEWER's workspace; the remediation must
# use pr_fail (not i_am_blocked — a reviewer has no i_am_blocked verb) so the
# PR returns to needs_revision for the dev to fix the environment.
monkeypatch.setattr(settings, "toolchain_match_enabled", True)
c = _make_choreographer(status="broken")
env = await c._toolchain_broken_guard(uuid4(), MagicMock(), reviewer=True)
@@ -118,9 +116,8 @@ async def test_guard_reviewer_remediation_uses_pr_fail_not_i_am_blocked(
async def test_guard_dev_remediation_still_uses_i_am_blocked(
monkeypatch: pytest.MonkeyPatch,
) -> None:
# F044: the dev (i_am_done) path keeps i_am_blocked — a dev DOES have that
# verb, so the original remediation is correct there. The reviewer flag must
# not change the dev-path wording.
# the dev (i_am_done) path keeps i_am_blocked — a dev has that verb, so the
# reviewer flag must not change the dev-path wording.
monkeypatch.setattr(settings, "toolchain_match_enabled", True)
c = _make_choreographer(status="broken")
env = await c._toolchain_broken_guard(uuid4(), MagicMock())