mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs
Post-audit sweep over the 135 audit-fix commits since19a474d3: 1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token from docstring openings across 211 blocks / ~626 lines. The CEO flagged these twice: audit-issue IDs in code confuse future devs/agents. The descriptive text is preserved; only the Fxxx token is removed (and bloated narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant). 2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines). 3. Added missing behavior-change docs for the audit-fix batch: prompts/roles (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets, agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience, conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm, main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation; megatask; task-claiming workflows). Comment/docstring/prose ONLY — zero code-line edits (verified: the diff contains no def/class/return/if/for/await/assignment/call lines). Gates green: ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures are the pre-existing sync_branch tracing-decision gap (B1,250be5c2) — not sweep-caused and tracked separately.
This commit is contained in:
@@ -508,12 +508,9 @@ class TestRateLimitTrackerActivateOnParking:
|
||||
assert env.status == "in_progress"
|
||||
|
||||
async def test_activate_failure_is_logged_not_silent(self) -> None:
|
||||
"""F045: an activate() failure must be logged loudly, not bare-suppressed.
|
||||
|
||||
The probe-resume loop is tracker-driven, so a silent activate failure
|
||||
strands every parked agent in WAITING_LONG with no probe ever running.
|
||||
A loud error log makes the stranded-fleet condition visible to
|
||||
operators (and pairs with the orchestrator's in-memory fallback sweep).
|
||||
"""An activate() failure must be logged loudly, not bare-suppressed —
|
||||
the probe-resume loop is tracker-driven, so a silent failure strands
|
||||
every parked agent in WAITING_LONG with no probe ever running.
|
||||
"""
|
||||
agent_id = uuid4()
|
||||
task_id = uuid4()
|
||||
|
||||
Reference in New Issue
Block a user