External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs

Browse Source 
Post-audit sweep over the 135 audit-fix commits since 19a474d3:

1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token
   from docstring openings across 211 blocks / ~626 lines. The CEO flagged
   these twice: audit-issue IDs in code confuse future devs/agents. The
   descriptive text is preserved; only the Fxxx token is removed (and bloated
   narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant).
2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines).
3. Added missing behavior-change docs for the audit-fix batch: prompts/roles
   (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets,
   agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience,
   conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm,
   main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation;
   megatask; task-claiming workflows).

Comment/docstring/prose ONLY — zero code-line edits (verified: the diff
contains no def/class/return/if/for/await/assignment/call lines). Gates green:
ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures
are the pre-existing sync_branch tracing-decision gap (B1, 250be5c2) — not
sweep-caused and tracked separately.
This commit is contained in:
Renn F
2026-06-29 01:25:40 +02:00
parent fb850e8235
commit 3441e37120
131 changed files with 842 additions and 1391 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/test_task_service_basics.py
+8 -10
View File
@@ -1467,10 +1467,9 @@ async def _gate_task(task_setup: dict, db_session: AsyncSession) -> Any:
async def test_pr_gate_claim_rejects_second_reviewer_race(
task_setup: dict, db_session: AsyncSession
) -> None:
"""F114: a second PR-reviewer race-claiming a gate task already claimed by a
reviewer must be refused (last-write-wins would otherwise overwrite the
first reviewer's claim and the first reviewer's pr_pass/pr_fail would
actor-mismatch)."""
"""A second PR-reviewer race-claiming a gate task already claimed by another
reviewer is refused, so the first reviewer's claim and subsequent
pr_pass/pr_fail actor-checks are not overwritten."""
svc = task_setup["svc"]
reviewer1 = _reviewer("R1")
reviewer2 = _reviewer("R2")
@@ -1497,10 +1496,9 @@ async def test_pr_gate_claim_rejects_second_reviewer_race(
async def test_pr_gate_claim_allows_first_reviewer_when_pm_owns_root(
task_setup: dict, db_session: AsyncSession
) -> None:
"""F114 regression guard: the gate task is owned by the PM at entry
(submit_for_review does not clear ownership), so the FIRST reviewer must
still be allowed to claim — the guard only rejects a competing REVIEWER
claim, not the PM owner."""
"""The first reviewer can still claim a gate task owned by the PM at entry
(submit_for_review does not clear ownership); the guard only rejects a
competing REVIEWER claim, not the PM owner."""
svc = task_setup["svc"]
pm = _pm("PM")
reviewer = _reviewer("R")
@@ -1526,8 +1524,8 @@ async def test_pr_gate_claim_allows_first_reviewer_when_pm_owns_root(
async def test_pr_gate_claim_idempotent_for_same_reviewer(
task_setup: dict, db_session: AsyncSession
) -> None:
"""F114: a reviewer re-claiming its OWN gate claim is idempotent (allowed),
not rejected — the guard only refuses a DIFFERENT reviewer."""
"""A reviewer re-claiming its own gate claim is idempotent (allowed); the
guard only refuses a different reviewer."""
svc = task_setup["svc"]
reviewer = _reviewer("R")
db_session.add(reviewer)