mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs
Post-audit sweep over the 135 audit-fix commits since19a474d3: 1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token from docstring openings across 211 blocks / ~626 lines. The CEO flagged these twice: audit-issue IDs in code confuse future devs/agents. The descriptive text is preserved; only the Fxxx token is removed (and bloated narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant). 2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines). 3. Added missing behavior-change docs for the audit-fix batch: prompts/roles (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets, agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience, conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm, main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation; megatask; task-claiming workflows). Comment/docstring/prose ONLY — zero code-line edits (verified: the diff contains no def/class/return/if/for/await/assignment/call lines). Gates green: ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures are the pre-existing sync_branch tracing-decision gap (B1,250be5c2) — not sweep-caused and tracked separately.
This commit is contained in:
@@ -102,13 +102,10 @@ async def test_explicit_dep_update_paths_scope(tmp_path: Path) -> None:
|
||||
async def test_probe_holds_read_clone_lock_across_local_clone(
|
||||
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
||||
) -> None:
|
||||
"""F116: the dep-update probe must hold the read-clone lock for the
|
||||
duration of the local ``git clone --local`` from the read clone, so a
|
||||
concurrent ``ensure_read_clone`` → ``_sync_read_clone`` (fetch + hard-reset
|
||||
to origin's default branch) cannot mutate the read clone mid-clone. The
|
||||
lock is released before the upgrade runs on the independent copy (the
|
||||
upgrade never touches the read clone, so holding the lock past the clone
|
||||
would needlessly block conventions reads for the upgrade duration)."""
|
||||
"""The dep-update probe holds the read-clone lock across the local
|
||||
``git clone --local`` so a concurrent ``_sync_read_clone`` cannot mutate the
|
||||
read clone mid-clone; released before the upgrade (which runs on an
|
||||
independent copy)."""
|
||||
read_clone = _make_read_clone(tmp_path)
|
||||
svc = _svc(read_clone)
|
||||
# Unique slug → a fresh lock not shared with any other test.
|
||||
|
||||
Reference in New Issue
Block a user