External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(conventions): baseline asserts the universal hygiene block rule, not a placement rule

Browse Source 
The baseline-constraint and conventions-map integration tests asserted 'no models in routers' — the old UNIVERSAL block default. Now that placement rules are scan-derived (only seeded where the target module exists), an empty-scan test project carries no_models_in_routers no longer; the universal block rule is no_lint_suppressions. Updated the five assertions accordingly; behaviour (baseline attaches, isn't suppressed, is idempotent) is unchanged.
This commit is contained in:
Renn F
2026-06-22 15:19:50 +02:00
parent 3baac6dcd8
commit 2bbd1c2e70
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/test_conventions_service.py
+1 -1
View File
@@ -133,7 +133,7 @@ async def test_baseline_constraints_include_block_rules(
constraints = await get_conventions_service(db_session).baseline_constraints( constraints = await get_conventions_service(db_session).baseline_constraints(
project project
) )
assert any("no models in routers" in c for c in constraints) assert any("no lint suppressions" in c for c in constraints)
async def test_render_ambient_block_is_bounded( async def test_render_ambient_block_is_bounded(
tests/integration/test_project_conventions_routes.py
+1 -1
View File
@@ -81,7 +81,7 @@ async def test_get_conventions_returns_map_and_health(client: AsyncClient) -> No
resp = await client.get(f"/api/projects/{project_id}/conventions", headers=_HDR) resp = await client.get(f"/api/projects/{project_id}/conventions", headers=_HDR)
assert resp.status_code == HTTPStatus.OK assert resp.status_code == HTTPStatus.OK
body = resp.json() body = resp.json()
assert body["standard"]["rules"]["no_models_in_routers"]["level"] == "block" assert body["standard"]["rules"]["no_lint_suppressions"]["level"] == "block"
assert body["health"]["status"] in {"missing", "unknown", "ok", "degraded"} assert body["health"]["status"] in {"missing", "unknown", "ok", "degraded"}
tests/integration/test_task_baseline_constraints.py
+3 -3
View File
@@ -70,7 +70,7 @@ async def test_baseline_attached_when_flag_on(
task = await TaskService(db_session).create(_req(agent, project, "Do the work")) task = await TaskService(db_session).create(_req(agent, project, "Do the work"))
assert task.description is not None assert task.description is not None
assert "## Constraints" in task.description assert "## Constraints" in task.description
assert "no models in routers" in task.description assert "no lint suppressions" in task.description
async def test_flag_off_attaches_nothing( async def test_flag_off_attaches_nothing(
@@ -93,7 +93,7 @@ async def test_baseline_not_suppressed_by_agent_constraints_section(
task = await TaskService(db_session).create(_req(agent, project, seeded)) task = await TaskService(db_session).create(_req(agent, project, seeded))
assert task.description is not None assert task.description is not None
assert "a task-specific note" in task.description assert "a task-specific note" in task.description
assert "no models in routers" in task.description assert "no lint suppressions" in task.description
async def test_baseline_attach_is_idempotent( async def test_baseline_attach_is_idempotent(
@@ -107,4 +107,4 @@ async def test_baseline_attach_is_idempotent(
await svc._attach_baseline_constraints(task) await svc._attach_baseline_constraints(task)
assert task.description == before assert task.description == before
assert task.description is not None assert task.description is not None
assert task.description.count("no models in routers") == 1 assert task.description.count("no lint suppressions") == 1