External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[F058] release-readiness: non-empty bump plan on first release

Browse Source 
_canonical_bump_files derived the bump set from the previous
chore(release): commit. On the first release there is no such commit,
so it returned [] -> assess set version_bump_plan=[] -> the executor
published a tag with no files bumped (a no-op masquerading as X.Y.Z).

Fall back to the version-reference scan when no prior release commit
exists: the files currently embedding the version are exactly the set a
first release must bump, and the set the first release commit then
records as canonical for subsequent releases. Read-only derivation; the
CEO-approval gate and fail-closed executor are untouched.
This commit is contained in:
Renn F
2026-06-28 16:11:16 +02:00
parent bffb0b7200
commit 23d6573f7f
2 changed files with 149 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
roboco/services/release_readiness.py
+15 -6
View File
@@ -412,14 +412,23 @@ def _tracked_files_with_version(root: Path, version: str) -> list[str]:
return sorted(line.strip() for line in raw.splitlines() if line.strip())
def _canonical_bump_files(root: Path) -> list[str]:
def _canonical_bump_files(root: Path, version: str) -> list[str]:
# Subsequent releases derive the canonical bump set from the previous
# ``chore(release):`` commit's touched files — the historical record of
# what a release bumps.
sha = _run_git(
root, ["log", "--grep", "^chore(release):", "-n1", "--format=%H"]
).strip()
if not sha:
return []
raw = _run_git(root, ["show", "--name-only", "--format=", sha])
return sorted(line.strip() for line in raw.splitlines() if line.strip())
if sha:
raw = _run_git(root, ["show", "--name-only", "--format=", sha])
return sorted(line.strip() for line in raw.splitlines() if line.strip())
# F058: the FIRST release has no prior ``chore(release):`` commit, so the
# historical derivation returns ``[]`` and the executor would publish a tag
# with no files bumped (a no-op release masquerading as X.Y.Z). Fall back to
# the version-reference scan — the files currently embedding the version are
# exactly the set a first release must bump, and the set the first release
# commit then records as canonical for every subsequent release. Read-only.
return _tracked_files_with_version(root, version)
def _new_migrations(root: Path, tag: str | None) -> list[str]:
@@ -498,7 +507,7 @@ def gather_snapshot(
last_tag=tag,
commits=_commits_since(root, tag),
tracked_files_with_version=_tracked_files_with_version(root, version),
canonical_bump_files=_canonical_bump_files(root),
canonical_bump_files=_canonical_bump_files(root, version),
changelog_text=_read_changelog(root),
new_migrations=_new_migrations(root, tag),
migration_head_count=_migration_head_count(root),