mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
chore(board): revive dormant board wiring — research key, pitch flow, auditor playbooks (#684)
* chore(compose): pass research key/provider + provisioning token/org through to the orchestrator ROBOCO_RESEARCH_API_KEY / ROBOCO_RESEARCH_PROVIDER and ROBOCO_PROVISIONING_TOKEN / ROBOCO_PROVISIONING_ORG were absent from every compose environment stanza, so .env values never reached the container: research silently ran on the NullProvider (empty results forever) and any approved pitch died on ProvisioningDisabledError. .env.example also falsely claimed the provisioning creds are panel-managed. * feat(board): pitch CEO notification + auditor playbook-draft surfacing A proposed pitch now nudges the CEO (APPROVAL notification + Telegram link to the Pitches tab, best-effort — a send failure never fails the verb). auditor_triage surfaces the oldest pending playbook draft once anomalies are clear — the curation verbs were granted but nothing ever pointed the Auditor at the review queue; the scheduled audit prompt names the discovery path. * docs(prompts): pitch doctrine section + auditor reply-only-dm drift fix board.md never mentioned the pitch verb, so no board agent ever had a reason to call it — it gets a dedicated section mirroring the roadmap/spotlight ones, plus a roadmap-exploration escape hatch (needs-its-own-repo ideas pitch instead). product-owner.md gains its missing propose_roadmap + pitch entries. The flat 'Auditor has no dm' claims are corrected to the real grant: never initiates, reply-only in a CEO-opened thread. Doctrine guarded by a prompt-content test. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
@@ -2,6 +2,7 @@
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from typing import Any
|
||||
from unittest.mock import AsyncMock, MagicMock
|
||||
from uuid import uuid4
|
||||
|
||||
@@ -9,7 +10,7 @@ import pytest
|
||||
from roboco.services.gateway.content_actions import ContentActions, ContentActionsDeps
|
||||
|
||||
|
||||
def _actions(role: str) -> ContentActions:
|
||||
def _actions(role: str, *, notification_delivery: Any = None) -> ContentActions:
|
||||
task = MagicMock()
|
||||
agent = MagicMock()
|
||||
agent.role = role
|
||||
@@ -22,6 +23,7 @@ def _actions(role: str) -> ContentActions:
|
||||
journal=MagicMock(),
|
||||
workspace=MagicMock(),
|
||||
notifications=MagicMock(),
|
||||
notification_delivery=notification_delivery,
|
||||
)
|
||||
return ContentActions(deps)
|
||||
|
||||
@@ -75,3 +77,54 @@ async def test_pitch_rejects_non_cell_target() -> None:
|
||||
target_cells=["board"],
|
||||
)
|
||||
assert env.error == "invalid_state"
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_pitch_notifies_ceo_on_success(monkeypatch: pytest.MonkeyPatch) -> None:
|
||||
"""A successful pitch nudges the CEO via the notification-delivery seam."""
|
||||
created = MagicMock()
|
||||
created.id = uuid4()
|
||||
svc = MagicMock()
|
||||
svc.create = AsyncMock(return_value=created)
|
||||
monkeypatch.setattr("roboco.services.pitch.get_pitch_service", lambda _s: svc)
|
||||
notification_delivery = AsyncMock()
|
||||
env = await _actions(
|
||||
"product_owner", notification_delivery=notification_delivery
|
||||
).pitch(
|
||||
agent_id=uuid4(),
|
||||
title="Widget",
|
||||
slug="widget",
|
||||
problem="people need widgets",
|
||||
proposed_solution="build a widget service",
|
||||
target_cells=["backend", "frontend"],
|
||||
)
|
||||
assert env.error is None
|
||||
assert env.status == "proposed"
|
||||
notification_delivery.notify_ceo_of_pitch.assert_awaited_once_with(pitch=created)
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_pitch_survives_notification_failure(
|
||||
monkeypatch: pytest.MonkeyPatch,
|
||||
) -> None:
|
||||
"""A CEO-notification failure never fails pitch() — best-effort only."""
|
||||
created = MagicMock()
|
||||
created.id = uuid4()
|
||||
svc = MagicMock()
|
||||
svc.create = AsyncMock(return_value=created)
|
||||
monkeypatch.setattr("roboco.services.pitch.get_pitch_service", lambda _s: svc)
|
||||
notification_delivery = AsyncMock()
|
||||
notification_delivery.notify_ceo_of_pitch.side_effect = RuntimeError("db down")
|
||||
env = await _actions(
|
||||
"product_owner", notification_delivery=notification_delivery
|
||||
).pitch(
|
||||
agent_id=uuid4(),
|
||||
title="Widget",
|
||||
slug="widget",
|
||||
problem="people need widgets",
|
||||
proposed_solution="build a widget service",
|
||||
target_cells=["backend", "frontend"],
|
||||
)
|
||||
assert env.error is None
|
||||
assert env.status == "proposed"
|
||||
notification_delivery.notify_ceo_of_pitch.assert_awaited_once()
|
||||
|
||||
Reference in New Issue
Block a user