mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
chore(board): revive dormant board wiring — research key, pitch flow, auditor playbooks (#684)
* chore(compose): pass research key/provider + provisioning token/org through to the orchestrator ROBOCO_RESEARCH_API_KEY / ROBOCO_RESEARCH_PROVIDER and ROBOCO_PROVISIONING_TOKEN / ROBOCO_PROVISIONING_ORG were absent from every compose environment stanza, so .env values never reached the container: research silently ran on the NullProvider (empty results forever) and any approved pitch died on ProvisioningDisabledError. .env.example also falsely claimed the provisioning creds are panel-managed. * feat(board): pitch CEO notification + auditor playbook-draft surfacing A proposed pitch now nudges the CEO (APPROVAL notification + Telegram link to the Pitches tab, best-effort — a send failure never fails the verb). auditor_triage surfaces the oldest pending playbook draft once anomalies are clear — the curation verbs were granted but nothing ever pointed the Auditor at the review queue; the scheduled audit prompt names the discovery path. * docs(prompts): pitch doctrine section + auditor reply-only-dm drift fix board.md never mentioned the pitch verb, so no board agent ever had a reason to call it — it gets a dedicated section mirroring the roadmap/spotlight ones, plus a roadmap-exploration escape hatch (needs-its-own-repo ideas pitch instead). product-owner.md gains its missing propose_roadmap + pitch entries. The flat 'Auditor has no dm' claims are corrected to the real grant: never initiates, reply-only in a CEO-opened thread. Doctrine guarded by a prompt-content test. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
@@ -0,0 +1,53 @@
|
||||
"""Board pitch doctrine + the Auditor dm nuance are actually in the prose.
|
||||
|
||||
Guards two prompt-drift classes: the `pitch` verb had no doctrine section
|
||||
anywhere (no board agent ever had a reason to call it), and board.md /
|
||||
auditor.md both flatly claimed the Auditor has NO `dm` when role_config.py
|
||||
grants it a reply-only, CEO-thread-only `dm`/`read_a2a`.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from roboco.agents.factories._base import _get_prompts_base_path, _load_layer
|
||||
|
||||
_PROMPTS = _get_prompts_base_path()
|
||||
|
||||
|
||||
def test_board_role_prompt_documents_pitch() -> None:
|
||||
text = _load_layer(_PROMPTS / "roles" / "board.md")
|
||||
assert text, "board.md is missing or empty"
|
||||
assert "pitch(" in text
|
||||
assert "## Pitching a new product" in text
|
||||
|
||||
|
||||
def test_product_owner_identity_lists_propose_roadmap_and_pitch() -> None:
|
||||
text = _load_layer(_PROMPTS / "identities" / "product-owner.md")
|
||||
assert text, "product-owner.md is missing or empty"
|
||||
assert "propose_roadmap" in text
|
||||
assert "pitch(" in text
|
||||
|
||||
|
||||
def test_head_marketing_identity_lists_pitch() -> None:
|
||||
text = _load_layer(_PROMPTS / "identities" / "head-marketing.md")
|
||||
assert text, "head-marketing.md is missing or empty"
|
||||
assert "pitch(" in text
|
||||
|
||||
|
||||
def test_board_role_prompt_no_longer_claims_flat_no_dm_for_auditor() -> None:
|
||||
text = _load_layer(_PROMPTS / "roles" / "board.md")
|
||||
assert "The Auditor is silent: read-only, no `dm`" not in text
|
||||
assert "You have no `dm`/`escalate_*`" not in text
|
||||
assert "reply in-thread when the CEO opens a DM with it" in text
|
||||
|
||||
|
||||
def test_auditor_identity_no_longer_claims_flat_no_dm() -> None:
|
||||
text = _load_layer(_PROMPTS / "identities" / "auditor.md")
|
||||
assert text, "auditor.md is missing or empty"
|
||||
assert "You have **no** `dm` verb" not in text
|
||||
assert "only to read and reply in-thread when the CEO opens a DM" in text
|
||||
|
||||
|
||||
def test_auditor_identity_documents_playbook_discovery_via_triage() -> None:
|
||||
text = _load_layer(_PROMPTS / "identities" / "auditor.md")
|
||||
assert "pending playbook draft" in text
|
||||
assert "triage()" in text
|
||||
Reference in New Issue
Block a user