mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[27208d92] Consolidate Cockpit/Goals/Secretary/Pitches into a Business page (#184)
* [0c66b856] Frontend: Build tabbed Business page consolidating Goals/Secretary/Pitches (#183) * [c9f00d0d] feat(business): add /business tabbed page consolidating Goals, Secretary, Pitches (#182) - Create src/app/(dashboard)/business/page.tsx with URL-driven Tabs (goals|secretary|pitches), reading ?tab= via useSearchParams; defaults to 'goals' - Create src/components/business/goals-tab.tsx: key-introspected form fields for objectives items and operating_policy (no raw JSON textareas), updated_at/updated_by metadata, skeleton loading, OfflineState on error - Create src/components/business/secretary-tab.tsx: ReactMarkdown (GFM) chat bubbles, structured directive cards with labeled key-value rows, RequiredNotesDialog for reject, skeleton loading, OfflineState on error - Create src/components/business/pitches-tab.tsx: sub-header Refresh button, PitchCard skeleton loading, OfflineState on error (not empty-state text), RequiredNotesDialog for both Approve and Reject - Create src/components/ui/required-notes-dialog.tsx: Submit disabled on empty/whitespace, Cancel closes without action, state resets on each open via key pattern - Update sidebar.tsx: remove Cockpit/Company Goals/Secretary/Pitches entries, add single Business entry (Building2 icon, /business) - Replace company-goals/page.tsx, secretary/page.tsx, pitches/page.tsx with server-side redirect() to /business?tab=X - Replace cockpit/page.tsx with notFound() (404) - All tabs: shadcn Card + Skeleton, sonner toast for success/error Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> * [e3e5ff9b] feat(dashboard): add StrategySignalsPanel next to CeoApprovalQueue in a 2-column grid layout (#181) Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> --------- Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> * refactor(panel): delete the consolidated old routes instead of stubbing them cockpit/company-goals/secretary/pitches are fully consolidated into /business, so the old route pages are dead code. Remove the four page.tsx files outright rather than keep redirect/404 stubs — the clean move is to delete, not add. The sidebar already points only at /business; no internal links reference the old routes (the remaining /company-goals|/secretary|/pitches|/cockpit strings are backend API paths the API clients call, unaffected). Old bookmarks now resolve to Next's default 404, which is correct for a removed route. * perf(cockpit): light /cockpit/signals endpoint for the Dashboard panel The relocated Strategy Signals panel was calling /cockpit/summary, which runs the whole fan-out (company goals + usage/spend + task-counts + pitches + strategy assess) just to read the signals. Add CockpitService.signals() + GET /api/cockpit/signals (CockpitSignals schema, same _COCKPIT_ROLES gate) that runs only StrategyEngine.assess(), and repoint the panel (+ cockpitApi.signals() client method, CockpitSignal type). Now the Dashboard fetches only what it shows. Backend gated: ruff + full mypy + 6 cockpit tests green (live DB). --------- Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
Renzo F
co-authored by
Frontend Developer 1
Frontend Developer 2
Renn F
Frontend Developer 1
Frontend Developer 2
Renn F
parent
a89d3cc885
commit
1757659754
@@ -0,0 +1,111 @@
|
||||
"use client";
|
||||
|
||||
import { useState } from "react";
|
||||
import {
|
||||
Dialog,
|
||||
DialogContent,
|
||||
DialogDescription,
|
||||
DialogFooter,
|
||||
DialogHeader,
|
||||
DialogTitle,
|
||||
} from "@/components/ui/dialog";
|
||||
import { Button } from "@/components/ui/button";
|
||||
import { Textarea } from "@/components/ui/textarea";
|
||||
import { Label } from "@/components/ui/label";
|
||||
|
||||
interface RequiredNotesDialogProps {
|
||||
open: boolean;
|
||||
onOpenChange: (open: boolean) => void;
|
||||
/** Title shown in the dialog header */
|
||||
title?: string;
|
||||
/** Description shown below the title */
|
||||
description?: string;
|
||||
/** Label for the notes textarea */
|
||||
notesLabel?: string;
|
||||
/** Placeholder text for the textarea */
|
||||
placeholder?: string;
|
||||
/** Called with the entered notes when the user clicks Submit */
|
||||
onSubmit: (notes: string) => void;
|
||||
/** Whether the submit action is currently pending (disables buttons) */
|
||||
isPending?: boolean;
|
||||
/** Label for the submit button */
|
||||
submitLabel?: string;
|
||||
}
|
||||
|
||||
/**
|
||||
* A dialog that requires the user to enter a non-empty reason / notes before
|
||||
* confirming a destructive or significant action. The Submit button is
|
||||
* disabled while the notes textarea is empty or whitespace-only. Cancel
|
||||
* closes the dialog without invoking `onSubmit`.
|
||||
*
|
||||
* The dialog is keyed on `open` so its internal state resets cleanly on each
|
||||
* open; this avoids a `setState-in-effect` pattern.
|
||||
*/
|
||||
function RequiredNotesDialogInner({
|
||||
open,
|
||||
onOpenChange,
|
||||
title = "Add a note",
|
||||
description = "Please provide a reason before continuing.",
|
||||
notesLabel = "Notes",
|
||||
placeholder = "Enter your reason…",
|
||||
onSubmit,
|
||||
isPending = false,
|
||||
submitLabel = "Submit",
|
||||
}: RequiredNotesDialogProps) {
|
||||
const [notes, setNotes] = useState("");
|
||||
|
||||
const isBlank = notes.trim() === "";
|
||||
|
||||
const handleSubmit = () => {
|
||||
if (isBlank || isPending) return;
|
||||
onSubmit(notes.trim());
|
||||
};
|
||||
|
||||
const handleCancel = () => {
|
||||
onOpenChange(false);
|
||||
};
|
||||
|
||||
return (
|
||||
<Dialog open={open} onOpenChange={onOpenChange}>
|
||||
<DialogContent>
|
||||
<DialogHeader>
|
||||
<DialogTitle>{title}</DialogTitle>
|
||||
{description && (
|
||||
<DialogDescription>{description}</DialogDescription>
|
||||
)}
|
||||
</DialogHeader>
|
||||
|
||||
<div className="space-y-2">
|
||||
<Label htmlFor="required-notes">{notesLabel}</Label>
|
||||
<Textarea
|
||||
id="required-notes"
|
||||
value={notes}
|
||||
onChange={(e) => setNotes(e.target.value)}
|
||||
placeholder={placeholder}
|
||||
rows={4}
|
||||
disabled={isPending}
|
||||
/>
|
||||
</div>
|
||||
|
||||
<DialogFooter>
|
||||
<Button variant="outline" onClick={handleCancel} disabled={isPending}>
|
||||
Cancel
|
||||
</Button>
|
||||
<Button onClick={handleSubmit} disabled={isBlank || isPending}>
|
||||
{isPending ? "Submitting…" : submitLabel}
|
||||
</Button>
|
||||
</DialogFooter>
|
||||
</DialogContent>
|
||||
</Dialog>
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Exported wrapper that remounts the inner component each time the dialog
|
||||
* opens, giving us a fresh empty notes field without using setState-in-effect.
|
||||
*/
|
||||
export function RequiredNotesDialog(props: RequiredNotesDialogProps) {
|
||||
// Using open as the key causes the inner component to remount (and reset its
|
||||
// local state) each time the dialog transitions from closed → open.
|
||||
return <RequiredNotesDialogInner key={String(props.open)} {...props} />;
|
||||
}
|
||||
Reference in New Issue
Block a user