Feature/architectural conventions standard (#243)

* feat(conventions): standard schema models + effective-map merge

* feat(conventions): tree-sitter Python classifier + placement checks

* feat(conventions): TS classifier, hygiene/custom checks, runner + CLI

* feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration

* feat(conventions): repo auto-scan + scaffold draft renderer

* feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore)

* feat(conventions): auto-scaffold on project registration (flag-gated)

* feat(conventions): TaskDescription.constraints + auto-baseline attach

* feat(conventions): ambient architecture-map injection at spawn

* test(conventions): subprocess CLI smoke for the agent-image entrypoint

* feat(conventions): block i_am_done on block-level convention violations

* feat(conventions): block pr_pass on unresolved convention violations

* feat(conventions): surface convention findings into QA evidence

* docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer

* feat(conventions): panel Conventions tab + flag toggle + parity

* test(conventions): end-to-end block, fix, and waiver through the gate

* refactor(conventions): extract pr_pass guards to keep pr_gate under the gate

* style(conventions): format the baseline-constraints attach in task.create

* test(conventions): type-annotate test helpers for the full mypy gate

* build(conventions): ignore types-PyYAML in deptry (mypy-only type stub)

* docs(conventions): document the standard in CLAUDE.md + PM prompt awareness

* fix(conventions): baseline constraints are non-suppressible (dedup-append)

* feat(conventions): scaffold on first workspace clone (threaded workspace)

* feat(conventions): multi-project ambient map for PO/Intake (per-product)

* feat(conventions): persist findings + violations-feed route (migration 044)

* feat(conventions): panel violations feed in the Conventions tab

* test(conventions): intake-spawn mock accepts the ambient layer kwarg

* fix(docker): ollama-init best-effort pull, gate startup on cached models present

A degraded/slow ollama registry made the model manifest re-check fail under
set -e, so ollama-init exited 1 and blocked the orchestrator's
service_completed_successfully gate — taking the whole stack down even though
both models were already cached. Pulls are now best-effort; success is gated on
the models being present, so a flaky registry can't down a cached deployment.

* refactor(content): drop dead TaskDescription.with_baseline_constraints

The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested.

---------

Co-authored-by: Renn F <rennf93@users.noreply.github.com>

tests/unit/services/test_workspace_conventions_scaffold.py

@@ -0,0 +1,75 @@
+"""The first-clone conventions scaffold hook: flag-gated, file-absent, once."""
+
+from __future__ import annotations
+
+from typing import TYPE_CHECKING, Any
+from unittest.mock import AsyncMock
+
+import roboco.services.workspace as ws_mod
+from roboco.config import settings
+from roboco.services.workspace import WorkspaceService
+
+if TYPE_CHECKING:
+    from pathlib import Path
+
+    import pytest
+
+
+class _SpyConventions:
+    def __init__(self) -> None:
+        self.scaffolded: list[Any] = []
+
+    async def scaffold(self, project: Any, *, workspace: Path) -> None:
+        self.scaffolded.append((project, workspace))
+
+
+def _install_spy(monkeypatch: pytest.MonkeyPatch) -> _SpyConventions:
+    ws_mod._SCAFFOLD_ATTEMPTED.clear()
+    spy = _SpyConventions()
+    monkeypatch.setattr(
+        "roboco.services.conventions.get_conventions_service", lambda _s: spy
+    )
+    return spy
+
+
+async def test_scaffold_fires_when_flag_on_and_file_absent(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    monkeypatch.setattr(settings, "conventions_enabled", True)
+    spy = _install_spy(monkeypatch)
+    svc = WorkspaceService(AsyncMock())
+    await svc._maybe_scaffold_conventions(object(), "proj-a", tmp_path)
+    assert len(spy.scaffolded) == 1
+
+
+async def test_no_scaffold_when_flag_off(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    monkeypatch.setattr(settings, "conventions_enabled", False)
+    spy = _install_spy(monkeypatch)
+    svc = WorkspaceService(AsyncMock())
+    await svc._maybe_scaffold_conventions(object(), "proj-b", tmp_path)
+    assert spy.scaffolded == []
+
+
+async def test_no_scaffold_when_file_already_present(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    monkeypatch.setattr(settings, "conventions_enabled", True)
+    spy = _install_spy(monkeypatch)
+    (tmp_path / ".roboco").mkdir()
+    (tmp_path / ".roboco" / "conventions.yml").write_text("version: 1\n")
+    svc = WorkspaceService(AsyncMock())
+    await svc._maybe_scaffold_conventions(object(), "proj-c", tmp_path)
+    assert spy.scaffolded == []
+
+
+async def test_scaffold_attempted_once_per_project(
+    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    monkeypatch.setattr(settings, "conventions_enabled", True)
+    spy = _install_spy(monkeypatch)
+    svc = WorkspaceService(AsyncMock())
+    await svc._maybe_scaffold_conventions(object(), "proj-d", tmp_path)
+    await svc._maybe_scaffold_conventions(object(), "proj-d", tmp_path)
+    assert len(spy.scaffolded) == 1