Feature/architectural conventions standard (#243)

* feat(conventions): standard schema models + effective-map merge

* feat(conventions): tree-sitter Python classifier + placement checks

* feat(conventions): TS classifier, hygiene/custom checks, runner + CLI

* feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration

* feat(conventions): repo auto-scan + scaffold draft renderer

* feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore)

* feat(conventions): auto-scaffold on project registration (flag-gated)

* feat(conventions): TaskDescription.constraints + auto-baseline attach

* feat(conventions): ambient architecture-map injection at spawn

* test(conventions): subprocess CLI smoke for the agent-image entrypoint

* feat(conventions): block i_am_done on block-level convention violations

* feat(conventions): block pr_pass on unresolved convention violations

* feat(conventions): surface convention findings into QA evidence

* docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer

* feat(conventions): panel Conventions tab + flag toggle + parity

* test(conventions): end-to-end block, fix, and waiver through the gate

* refactor(conventions): extract pr_pass guards to keep pr_gate under the gate

* style(conventions): format the baseline-constraints attach in task.create

* test(conventions): type-annotate test helpers for the full mypy gate

* build(conventions): ignore types-PyYAML in deptry (mypy-only type stub)

* docs(conventions): document the standard in CLAUDE.md + PM prompt awareness

* fix(conventions): baseline constraints are non-suppressible (dedup-append)

* feat(conventions): scaffold on first workspace clone (threaded workspace)

* feat(conventions): multi-project ambient map for PO/Intake (per-product)

* feat(conventions): persist findings + violations-feed route (migration 044)

* feat(conventions): panel violations feed in the Conventions tab

* test(conventions): intake-spawn mock accepts the ambient layer kwarg

* fix(docker): ollama-init best-effort pull, gate startup on cached models present

A degraded/slow ollama registry made the model manifest re-check fail under
set -e, so ollama-init exited 1 and blocked the orchestrator's
service_completed_successfully gate — taking the whole stack down even though
both models were already cached. Pulls are now best-effort; success is gated on
the models being present, so a flaky registry can't down a cached deployment.

* refactor(content): drop dead TaskDescription.with_baseline_constraints

The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested.

---------

Co-authored-by: Renn F <rennf93@users.noreply.github.com>

tests/unit/foundation/policy/content/test_task_description_constraints.py

@@ -0,0 +1,28 @@
+"""TaskDescription.constraints: renders as a section when present, else absent."""
+
+from __future__ import annotations
+
+from typing import Any
+
+from roboco.foundation.identity import Team
+from roboco.foundation.policy.content.models import TaskDescription, WorkUnit
+
+
+def _desc(**overrides: Any) -> TaskDescription:
+    fields: dict[str, Any] = {
+        "objective": "Build the thing properly",
+        "the_work": [WorkUnit(team=Team.BACKEND, summary="do the work", items=["a"])],
+        "acceptance_criteria": ["it works"],
+    }
+    fields.update(overrides)
+    return TaskDescription(**fields)
+
+
+def test_constraints_render_as_section() -> None:
+    md = _desc(constraints=["no models in routers"]).render_markdown()
+    assert "## Constraints" in md
+    assert "no models in routers" in md
+
+
+def test_no_constraints_section_when_empty() -> None:
+    assert "## Constraints" not in _desc().render_markdown()

tests/unit/foundation/policy/conventions/test_ts_parity.py

@@ -0,0 +1,28 @@
+"""The panel TS ConventionsStandard type mirrors the Python model fields.
+
+A drift here means the panel editor and the backend disagree on the shape of
+``.roboco/conventions.yml`` — caught at test time, not in production.
+"""
+
+from __future__ import annotations
+
+import re
+from pathlib import Path
+
+from roboco.foundation.policy.conventions.models import ConventionsStandard
+
+_REPO_ROOT = Path(__file__).resolve().parents[5]
+_TS_FILE = _REPO_ROOT / "panel" / "src" / "lib" / "api" / "conventions.ts"
+
+
+def _ts_interface_fields(text: str, name: str) -> set[str]:
+    match = re.search(rf"export interface {name} \{{(.+?)\n\}}", text, re.DOTALL)
+    assert match, f"interface {name} not found in conventions.ts"
+    return set(re.findall(r"^\s*(\w+)\s*[?:]", match.group(1), re.MULTILINE))
+
+
+def test_ts_standard_matches_python_fields() -> None:
+    text = _TS_FILE.read_text()
+    ts_keys = _ts_interface_fields(text, "ConventionsStandard")
+    py_keys = set(ConventionsStandard.model_fields.keys())
+    assert ts_keys == py_keys