mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Feature/architectural conventions standard (#243)
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
Renzo F
@@ -4,11 +4,14 @@ Project API Routes
|
||||
CRUD operations for managing git projects/repositories.
|
||||
"""
|
||||
|
||||
from typing import Annotated, cast
|
||||
from typing import TYPE_CHECKING, Annotated, cast
|
||||
from uuid import UUID
|
||||
|
||||
from fastapi import APIRouter, HTTPException, Query, status
|
||||
|
||||
if TYPE_CHECKING:
|
||||
from roboco.db.tables import ProjectTable
|
||||
|
||||
from roboco.api.deps import (
|
||||
CurrentAgentContext,
|
||||
DbSession,
|
||||
@@ -16,6 +19,10 @@ from roboco.api.deps import (
|
||||
require_pm_or_above,
|
||||
)
|
||||
from roboco.api.schemas.project import (
|
||||
ConventionFinding,
|
||||
ConventionsActionResponse,
|
||||
ConventionsHealthResponse,
|
||||
ConventionsResponse,
|
||||
ProjectCreateRequest,
|
||||
ProjectResponse,
|
||||
ProjectSummaryResponse,
|
||||
@@ -25,9 +32,14 @@ from roboco.api.schemas.project import (
|
||||
project_to_response,
|
||||
project_to_summary,
|
||||
)
|
||||
from roboco.foundation.policy.conventions.models import ConventionsStandard
|
||||
from roboco.models.base import Team
|
||||
from roboco.models.project import ProjectCreate, ProjectUpdate
|
||||
from roboco.services.project import get_project_service
|
||||
from roboco.services.conventions import (
|
||||
ScaffoldResult,
|
||||
get_conventions_service,
|
||||
)
|
||||
from roboco.services.project import ProjectService, get_project_service
|
||||
|
||||
router = APIRouter()
|
||||
|
||||
@@ -423,3 +435,101 @@ async def remove_agent_access(
|
||||
)
|
||||
|
||||
return project_to_response(updated)
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# CONVENTIONS ENDPOINTS
|
||||
# =============================================================================
|
||||
|
||||
|
||||
async def _get_project_or_404(
|
||||
service: ProjectService, project_id: str
|
||||
) -> "ProjectTable":
|
||||
"""Resolve a project by UUID or slug, raising 404 when absent."""
|
||||
try:
|
||||
project = await service.get(UUID(project_id))
|
||||
except ValueError:
|
||||
project = await service.get_by_slug(project_id)
|
||||
if project is None:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_404_NOT_FOUND,
|
||||
detail=f"Project not found: {project_id}",
|
||||
)
|
||||
return project
|
||||
|
||||
|
||||
def _action_response(result: ScaffoldResult) -> ConventionsActionResponse:
|
||||
return ConventionsActionResponse(
|
||||
pr_number=result.pr_number, branch=result.branch, created=result.created
|
||||
)
|
||||
|
||||
|
||||
@router.get("/{project_id}/conventions", response_model=ConventionsResponse)
|
||||
async def get_conventions(
|
||||
project_id: str,
|
||||
db: DbSession,
|
||||
_agent: CurrentAgentContext,
|
||||
) -> ConventionsResponse:
|
||||
"""Return the project's effective conventions map + its current health."""
|
||||
project = await _get_project_or_404(get_project_service(db), project_id)
|
||||
conv = get_conventions_service(db)
|
||||
standard = await conv.get_map(project)
|
||||
health = await conv.health(project)
|
||||
await db.commit()
|
||||
return ConventionsResponse(
|
||||
standard=standard.model_dump(mode="json"),
|
||||
health=ConventionsHealthResponse(
|
||||
status=health.status,
|
||||
head_sha=health.head_sha,
|
||||
last_ok_sha=health.last_ok_sha,
|
||||
),
|
||||
)
|
||||
|
||||
|
||||
@router.put("/{project_id}/conventions", response_model=ConventionsActionResponse)
|
||||
async def update_conventions(
|
||||
project_id: str,
|
||||
standard: ConventionsStandard,
|
||||
db: DbSession,
|
||||
agent: CurrentAgentContext,
|
||||
) -> ConventionsActionResponse:
|
||||
"""Commit an edited conventions standard back to the repo via a PR (PM+)."""
|
||||
require_pm_or_above(agent.role, "edit conventions")
|
||||
project = await _get_project_or_404(get_project_service(db), project_id)
|
||||
result = await get_conventions_service(db).commit_standard(project, standard)
|
||||
await db.commit()
|
||||
return _action_response(result)
|
||||
|
||||
|
||||
@router.post(
|
||||
"/{project_id}/conventions/restore", response_model=ConventionsActionResponse
|
||||
)
|
||||
async def restore_conventions(
|
||||
project_id: str,
|
||||
db: DbSession,
|
||||
agent: CurrentAgentContext,
|
||||
) -> ConventionsActionResponse:
|
||||
"""Re-commit the conventions file from the last-good map via a PR (PM+)."""
|
||||
require_pm_or_above(agent.role, "restore conventions")
|
||||
project = await _get_project_or_404(get_project_service(db), project_id)
|
||||
result = await get_conventions_service(db).restore(project)
|
||||
await db.commit()
|
||||
return _action_response(result)
|
||||
|
||||
|
||||
@router.get(
|
||||
"/{project_id}/conventions/findings",
|
||||
response_model=list[ConventionFinding],
|
||||
)
|
||||
async def get_conventions_findings(
|
||||
project_id: str,
|
||||
db: DbSession,
|
||||
_agent: CurrentAgentContext,
|
||||
limit: Annotated[int, Query(ge=1, le=200)] = 50,
|
||||
) -> list[ConventionFinding]:
|
||||
"""Recent architectural-conventions findings for the project (violations feed)."""
|
||||
project = await _get_project_or_404(get_project_service(db), project_id)
|
||||
rows = await get_conventions_service(db).recent_findings(
|
||||
UUID(str(project.id)), limit
|
||||
)
|
||||
return [ConventionFinding(**row) for row in rows]
|
||||
|
||||
Reference in New Issue
Block a user