mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Feature/architectural conventions standard (#243)
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
+15
-2
@@ -12,7 +12,7 @@ requires-python = ">=3.10,<3.15"
|
||||
dependencies = [
|
||||
# Core
|
||||
"pydantic",
|
||||
"pydantic-settings>=2.14.2",
|
||||
"pydantic-settings",
|
||||
# API
|
||||
"fastapi",
|
||||
"uvicorn[standard]",
|
||||
@@ -45,7 +45,11 @@ dependencies = [
|
||||
"cryptography", # utils/crypto.py — Fernet-encrypted project git tokens
|
||||
"packaging", # services/toolchain.py — PEP 440 requires-python resolution
|
||||
"pyyaml", # foundation/policy/conventions — .roboco/conventions.yml parse
|
||||
"claude-agent-sdk>=0.2.105",
|
||||
# Conventions validator (roboco.conventions) — tree-sitter ASTs, Python + TS
|
||||
"tree-sitter",
|
||||
"tree-sitter-python",
|
||||
"tree-sitter-typescript",
|
||||
"claude-agent-sdk",
|
||||
]
|
||||
|
||||
[project.optional-dependencies]
|
||||
@@ -170,6 +174,14 @@ select = [
|
||||
# bottom of policy/lifecycle.py at module-load time, so the validators must
|
||||
# defer their inverse imports until call time to avoid a cycle.
|
||||
"roboco/foundation/_validate_lifecycle.py" = ["PLC0415"]
|
||||
# The conventions validator loads tree-sitter grammars lazily, per language, so
|
||||
# the package imports without tree-sitter present and a missing grammar fails
|
||||
# loud at call time (GrammarUnavailable) instead of crashing the import.
|
||||
"roboco/conventions/grammars.py" = ["PLC0415"]
|
||||
# The conventions ambient-layer resolver defers its config + ConventionsService
|
||||
# imports so the prompt-composition utility stays decoupled from the heavy
|
||||
# service graph (it loads at every agent spawn).
|
||||
"roboco/agents/factories/_base.py" = ["PLC0415"]
|
||||
# Test fixtures that reload modules to test env-var-at-import-time behavior.
|
||||
# ARG002: ApiClient-subclassing fakes must keep the superclass parameter names
|
||||
# for mypy's override check, so unused override-stub args can't be renamed.
|
||||
@@ -393,6 +405,7 @@ DEP002 = [
|
||||
# Type stubs (used by mypy)
|
||||
"types-passlib",
|
||||
"types-python-jose",
|
||||
"types-PyYAML",
|
||||
# Documentation (CLI tools)
|
||||
"mkdocs",
|
||||
"mkdocs-material",
|
||||
|
||||
Reference in New Issue
Block a user