Changes Made

roboco/agents/base.py - Added proper workflow methods:
  - _qa_pass(task_id, qa_notes) - Calls /pass-qa endpoint
  - _qa_fail(task_id, qa_notes, issues) - Calls /fail-qa endpoint
  - _docs_complete(task_id, doc_notes?) - Calls /docs-complete endpoint
  - Marked old _mark_needs_revision, _mark_awaiting_documentation, _mark_awaiting_pm_review as DEPRECATED

  roboco/agents/qa.py - Fixed verdict phase:
  - Now uses _qa_pass() instead of _mark_awaiting_documentation()
  - Now uses _qa_fail() instead of _mark_needs_revision()
  - Properly passes QA notes and issue lists

  roboco/agents/documenter.py - Fixed submit phase:
  - Now uses _docs_complete() instead of _mark_awaiting_pm_review()
  - Properly passes documentation summary as notes
This commit is contained in:
Renn F
2025-12-24 23:34:42 +01:00
parent dd1b3394a7
commit 15f5be3f8b
16 changed files with 149 additions and 35 deletions
+6 -1
View File
@@ -451,7 +451,8 @@ tools:
# Communication
- roboco_channel_list, roboco_channel_history
- roboco_message_send, roboco_ask_question
- roboco_message_send, roboco_message_get, roboco_ask_question
- roboco_session_history_for_task # Get discussion history for your task
- roboco_report_blocker
# Claude Code Built-in
@@ -487,4 +488,8 @@ permissions:
journals_read:
- backend cell members (be-dev-1, be-dev-2, be-qa, be-doc, be-pm)
# Enforced Constraints (code enforces these rules)
task_visibility: team_only # You only see tasks assigned to your team
self_review: blocked # You cannot QA or document your own work
```
+2 -1
View File
@@ -230,7 +230,8 @@ tools:
# Team Journals (Read Cell Members)
- roboco_journal_read_team, roboco_journal_scope
- roboco_channel_list, roboco_channel_history
- roboco_message_send, roboco_ask_question
- roboco_message_send, roboco_message_get, roboco_ask_question
- roboco_session_history_for_task # Get discussion history for your task
```
## Permissions
+6 -1
View File
@@ -362,7 +362,8 @@ tools:
# Communication
- roboco_channel_list, roboco_channel_history
- roboco_message_send, roboco_ask_question
- roboco_message_send, roboco_message_get, roboco_ask_question
- roboco_session_history_for_task # Get discussion history for your task
- roboco_report_blocker
# Testing Tools
@@ -395,4 +396,8 @@ permissions:
- qa_pass_tasks
- qa_fail_tasks
- escalate_tasks
# Enforced Constraints (code enforces these rules)
task_visibility: team_only # You only see tasks for your team
self_review: blocked # You cannot QA tasks where you were the original developer
```
+6 -1
View File
@@ -361,7 +361,8 @@ tools:
# Communication
- roboco_channel_list, roboco_channel_history
- roboco_message_send, roboco_ask_question
- roboco_message_send, roboco_message_get, roboco_ask_question
- roboco_session_history_for_task # Get discussion history for your task
- roboco_report_blocker
# Claude Code Built-in
@@ -397,4 +398,8 @@ permissions:
journals_read:
- frontend cell members (fe-dev-1, fe-dev-2, fe-qa, fe-doc, fe-pm)
# Enforced Constraints (code enforces these rules)
task_visibility: team_only # You only see tasks assigned to your team
self_review: blocked # You cannot QA or document your own work
```
+2 -1
View File
@@ -228,7 +228,8 @@ tools:
# Team Journals (Read Cell Members)
- roboco_journal_read_team, roboco_journal_scope
- roboco_channel_list, roboco_channel_history
- roboco_message_send, roboco_ask_question
- roboco_message_send, roboco_message_get, roboco_ask_question
- roboco_session_history_for_task # Get discussion history for your task
```
## Permissions
+6 -1
View File
@@ -248,7 +248,8 @@ tools:
- roboco_journal_read_team, roboco_journal_scope
# Communication
- roboco_channel_list, roboco_channel_history
- roboco_message_send, roboco_ask_question
- roboco_message_send, roboco_message_get, roboco_ask_question
- roboco_session_history_for_task # Get discussion history for your task
```
## Permissions
@@ -276,4 +277,8 @@ permissions:
- qa_pass_tasks
- qa_fail_tasks
- escalate_tasks
# Enforced Constraints (code enforces these rules)
task_visibility: team_only # You only see tasks for your team
self_review: blocked # You cannot QA tasks where you were the original developer
```
+6 -1
View File
@@ -331,7 +331,8 @@ tools:
# Communication
- roboco_channel_list, roboco_channel_history
- roboco_message_send, roboco_ask_question
- roboco_message_send, roboco_message_get, roboco_ask_question
- roboco_session_history_for_task # Get discussion history for your task
- roboco_report_blocker
# Design Tools
@@ -364,4 +365,8 @@ permissions:
journals_read:
- ux_ui cell members (ux-dev, ux-qa, ux-doc, ux-pm)
# Enforced Constraints (code enforces these rules)
task_visibility: team_only # You only see tasks assigned to your team
self_review: blocked # You cannot QA or document your own work
```
+2 -1
View File
@@ -228,7 +228,8 @@ tools:
# Team Journals (Read Cell Members)
- roboco_journal_read_team, roboco_journal_scope
- roboco_channel_list, roboco_channel_history
- roboco_message_send, roboco_ask_question
- roboco_message_send, roboco_message_get, roboco_ask_question
- roboco_session_history_for_task # Get discussion history for your task
```
## Permissions
+6 -1
View File
@@ -246,7 +246,8 @@ tools:
- roboco_journal_read_team, roboco_journal_scope
# Communication
- roboco_channel_list, roboco_channel_history
- roboco_message_send, roboco_ask_question
- roboco_message_send, roboco_message_get, roboco_ask_question
- roboco_session_history_for_task # Get discussion history for your task
```
## Permissions
@@ -274,4 +275,8 @@ permissions:
- qa_pass_tasks
- qa_fail_tasks
- escalate_tasks
# Enforced Constraints (code enforces these rules)
task_visibility: team_only # You only see tasks for your team
self_review: blocked # You cannot QA tasks where you were the original developer
```