External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): exempt roboco-app[bot] from the CLA check (#710)

Browse Source 
The App the fleet pushes and opens PRs under authors the sync/merge commits
GitService creates when a task branch is brought up to date with its base, so
it is a committer on essentially every fleet PR. Unlike the agent identities
— whose roboco.tech emails map to no GitHub account, so CLA Assistant matches
them by the display names already allowlisted — the App maps to a real
account, and CLA Assistant demands a signature it cannot give: an App cannot
post the sign-off comment as itself.

The result is a permanently red `cla` check on fleet PRs (currently #703 and
#704) that no amount of rework can clear, which sends the PR reviewer round
another revision loop with nothing to fix.

Exempting it is also correct on the merits: the CLA exists to obtain
copyright assignment from human contributors, and the App commits on the
copyright holder's own behalf. Same form as the dependabot[bot] entry.

Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
Renzo F
2026-07-26 19:10:06 +02:00
committed by GitHub
co-authored by Renn F
parent a36a180b73
commit 0fe21b1f97
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/cla.yml
+12 -1
View File
@@ -41,4 +41,15 @@ jobs:
# the emails map to no GitHub account, so CLA Assistant identifies
# them by display name — allowlist those names, wildcarded per team
# family, mirroring roboco/seeds/initial_data.py's roster.
allowlist: "dependabot[bot],rennf93,Backend *,Frontend *,UX/UI *,Main PM,Product Owner,Head of Marketing,Auditor,Intake,Secretary,PR Reviewer,RoboCo Agent"
#
# roboco-app[bot] is the GitHub App the fleet pushes and opens PRs
# under. It authors the sync/merge commits GitService creates when a
# task branch is brought up to date with its base, so it is a
# committer on essentially every fleet PR — and unlike the agent
# identities it DOES map to a real GitHub account, so CLA Assistant
# demands a signature it can never give: an App cannot post the
# sign-off comment as itself. Exempting it is also correct on the
# merits, since the CLA exists to obtain copyright assignment from
# human contributors and the App commits on the copyright holder's
# own behalf. Same form as dependabot[bot] above.
allowlist: "dependabot[bot],roboco-app[bot],rennf93,Backend *,Frontend *,UX/UI *,Main PM,Product Owner,Head of Marketing,Auditor,Intake,Secretary,PR Reviewer,RoboCo Agent"