roboco/tests/unit/foundation/policy/content/test_validators.py

"""Tests for the shared content validators (``reject_trivial``).

``reject_trivial`` is the single non-empty / non-placeholder gate reused by
every structured-content field validator AND the gateway anti-soup guards. It
must reject: empty, too-short, a lone placeholder token, AND a string whose
every whitespace token is a placeholder (``wip wip``, ``tbd / na``).
"""

from __future__ import annotations

import pytest
from roboco.foundation.policy.content.validators import coerce_str_list, reject_trivial


def test_returns_trimmed_value_when_substantive() -> None:
    assert reject_trivial("  real content here  ", field="x") == "real content here"


@pytest.mark.parametrize("blank", ["", "   ", "\t\n"])
def test_rejects_empty(blank: str) -> None:
    with pytest.raises(ValueError, match="must not be empty"):
        reject_trivial(blank, field="summary")


def test_rejects_too_short() -> None:
    with pytest.raises(ValueError, match="at least 10 characters"):
        reject_trivial("short", field="summary", min_chars=10)


@pytest.mark.parametrize(
    "token", ["wip", "TBD", "asdf", "n/a", "none", "-", "...", "x"]
)
def test_rejects_lone_placeholder_token(token: str) -> None:
    with pytest.raises(ValueError, match="placeholder"):
        reject_trivial(token, field="summary")


@pytest.mark.parametrize(
    "soup",
    ["wip wip", "tbd / na", "todo todo todo", "asdf asdf asdf asdf", "none none"],
)
def test_rejects_all_filler_token_string(soup: str) -> None:
    # Every token is a placeholder — the whole string is soup even though it is
    # neither a single banned token nor below the length floor.
    with pytest.raises(ValueError, match="placeholder"):
        reject_trivial(soup, field="summary")


@pytest.mark.parametrize(
    "ok",
    [
        "none of the tests failed",  # 'none' present but not all-filler
        "fixed the x coordinate bug",  # 'x' present but not all-filler
        "rate_limited",  # a real substitute reason
        "LGTM, merging now",
    ],
)
def test_accepts_real_text_containing_a_filler_word(ok: str) -> None:
    assert reject_trivial(ok, field="reason", min_chars=3) == ok.strip()


# ---------------------------------------------------------------------------
# coerce_str_list — flatten an LLM's dict-wrapped list-of-strings to list[str].
# The agent sometimes emits a list[str] field as XML-ish <item>…</item> elements
# the Claude SDK parses into {"item": {"$text": "…"}}; left as dicts they crash
# a VARCHAR[] insert ("expected str, got dict") and dump str(dict) into prose.
# ---------------------------------------------------------------------------


def test_coerce_str_list_passes_plain_strings_through() -> None:
    assert coerce_str_list(["one", "two"]) == ["one", "two"]


def test_coerce_str_list_extracts_sdk_item_text_wrapper() -> None:
    # The exact shape from the live crash: [{"item": {"$text": "…"}}, ...].
    assert coerce_str_list(
        [{"item": {"$text": "UX-UI delivers a sketch"}}, {"item": "Spec lands first"}]
    ) == ["UX-UI delivers a sketch", "Spec lands first"]


def test_coerce_str_list_wraps_a_bare_dict() -> None:
    assert coerce_str_list({"$text": "only one"}) == ["only one"]


def test_coerce_str_list_wraps_a_bare_string() -> None:
    assert coerce_str_list("only one") == ["only one"]


def test_coerce_str_list_drops_non_string_junk() -> None:
    # A non-str, non-dict element is dropped — never passed to a VARCHAR[] column.
    assert coerce_str_list(["keep", 7, None, {"text": "nested"}]) == [
        "keep",
        "nested",
    ]


def test_coerce_str_list_recurses_into_nested_lists() -> None:
    assert coerce_str_list([["a", {"item": "b"}], "c"]) == ["a", "b", "c"]


def test_coerce_str_list_none_and_empty() -> None:
    assert coerce_str_list(None) == []
    assert coerce_str_list([]) == []