2026-06-25 21:11:36 +02:00
|
|
|
"""The orchestrator CI-watch loop: dormant when off, runs the engine when on.
|
|
|
|
|
|
|
|
|
|
Dormant unless ``ci_watch_enabled``; loads the watch set (opted-in projects, one
|
|
|
|
|
per repo), warns when enabled-but-empty, and runs CiWatchEngine.run_cycle each
|
|
|
|
|
interval. Separate from the single-repo self-heal loop.
|
|
|
|
|
"""
|
|
|
|
|
|
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
|
|
|
|
from contextlib import asynccontextmanager
|
|
|
|
|
from typing import Any
|
|
|
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
|
|
|
|
|
|
import pytest
|
|
|
|
|
from roboco.config import settings
|
|
|
|
|
from roboco.runtime.orchestrator import AgentOrchestrator
|
|
|
|
|
|
|
|
|
|
|
2026-06-29 05:38:21 +02:00
|
|
|
def _orch() -> Any:
|
2026-06-25 21:11:36 +02:00
|
|
|
return AgentOrchestrator.__new__(AgentOrchestrator)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_loop_noop_when_disabled(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
|
|
|
monkeypatch.setattr(settings, "ci_watch_enabled", False)
|
|
|
|
|
orch = _orch()
|
|
|
|
|
cycle = AsyncMock()
|
2026-06-29 05:38:21 +02:00
|
|
|
orch._run_ci_watch_cycle = cycle
|
2026-06-25 21:11:36 +02:00
|
|
|
await orch._ci_watch_loop() # must return immediately, no infinite loop
|
|
|
|
|
cycle.assert_not_awaited()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_load_watch_set_filters_enabled_one_per_repo() -> None:
|
|
|
|
|
orch = _orch()
|
2026-06-29 05:38:21 +02:00
|
|
|
# Same repo, SAME effective workflow (both fall back to the default) → one
|
|
|
|
|
# canonical entry; the opt-out is excluded.
|
|
|
|
|
on_a = MagicMock(
|
|
|
|
|
slug="be",
|
|
|
|
|
git_url="https://x/a.git",
|
|
|
|
|
ci_watch_enabled=True,
|
|
|
|
|
ci_watch_workflow=None,
|
|
|
|
|
)
|
|
|
|
|
on_a2 = MagicMock(
|
|
|
|
|
slug="fe",
|
|
|
|
|
git_url="https://x/a.git",
|
|
|
|
|
ci_watch_enabled=True,
|
|
|
|
|
ci_watch_workflow=None,
|
|
|
|
|
)
|
2026-06-25 21:11:36 +02:00
|
|
|
off = MagicMock(slug="c", git_url="https://x/c.git", ci_watch_enabled=False)
|
|
|
|
|
svc = MagicMock()
|
|
|
|
|
svc.list_all = AsyncMock(return_value=[on_a, on_a2, off])
|
|
|
|
|
with patch("roboco.services.project.get_project_service", return_value=svc):
|
|
|
|
|
watch = await orch._load_ci_watch_set(MagicMock())
|
2026-06-29 05:38:21 +02:00
|
|
|
assert len(watch) == 1 # opt-out excluded; same-repo + same-workflow collapsed
|
2026-06-25 21:11:36 +02:00
|
|
|
assert watch[0].git_url == "https://x/a.git"
|
|
|
|
|
|
|
|
|
|
|
2026-06-29 05:38:21 +02:00
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_load_watch_set_keeps_distinct_workflows_per_repo() -> None:
|
|
|
|
|
"""A monorepo's several cell-projects each carrying their OWN
|
|
|
|
|
``ci_watch_workflow`` must ALL be watched — collapsing to the canonical cell's
|
|
|
|
|
workflow would miss a red on the other cells' workflows (under-count). Same
|
|
|
|
|
repo, DIFFERENT workflows → one entry per (repo, workflow); per-git_url dedup
|
|
|
|
|
still prevents duplicate fix tasks for the repo."""
|
|
|
|
|
orch = _orch()
|
|
|
|
|
be = MagicMock(
|
|
|
|
|
slug="be",
|
|
|
|
|
git_url="https://x/a.git",
|
|
|
|
|
ci_watch_enabled=True,
|
|
|
|
|
ci_watch_workflow="backend-ci.yml",
|
|
|
|
|
)
|
|
|
|
|
fe = MagicMock(
|
|
|
|
|
slug="fe",
|
|
|
|
|
git_url="https://x/a.git",
|
|
|
|
|
ci_watch_enabled=True,
|
|
|
|
|
ci_watch_workflow="frontend-ci.yml",
|
|
|
|
|
)
|
|
|
|
|
svc = MagicMock()
|
|
|
|
|
svc.list_all = AsyncMock(return_value=[be, fe])
|
|
|
|
|
with patch("roboco.services.project.get_project_service", return_value=svc):
|
|
|
|
|
watch = await orch._load_ci_watch_set(MagicMock())
|
|
|
|
|
# distinct workflows both watched, NOT collapsed to one canonical cell —
|
|
|
|
|
# the set-equality assertion proves exactly-two (no magic-value literal).
|
|
|
|
|
workflows = {p.ci_watch_workflow for p in watch}
|
|
|
|
|
assert workflows == {"backend-ci.yml", "frontend-ci.yml"}
|
|
|
|
|
|
|
|
|
|
|
2026-06-26 01:43:08 +02:00
|
|
|
def _db_ctx(db: Any) -> Any:
|
2026-06-25 21:11:36 +02:00
|
|
|
@asynccontextmanager
|
|
|
|
|
async def _ctx() -> Any:
|
|
|
|
|
yield db
|
|
|
|
|
|
|
|
|
|
return _ctx
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_cycle_warns_and_skips_engine_when_empty() -> None:
|
|
|
|
|
orch = _orch()
|
2026-06-29 05:38:21 +02:00
|
|
|
orch._load_ci_watch_set = AsyncMock(return_value=[])
|
2026-06-25 21:11:36 +02:00
|
|
|
get_eng = MagicMock()
|
|
|
|
|
with (
|
|
|
|
|
patch("roboco.db.get_db_context", _db_ctx(MagicMock())),
|
|
|
|
|
patch("roboco.services.ci_watch_engine.get_ci_watch_engine", get_eng),
|
|
|
|
|
):
|
|
|
|
|
await orch._run_ci_watch_cycle()
|
|
|
|
|
get_eng.assert_not_called() # empty watch set → no engine run
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_cycle_runs_engine_when_watch_set_present() -> None:
|
|
|
|
|
orch = _orch()
|
|
|
|
|
watch = [MagicMock()]
|
2026-06-29 05:38:21 +02:00
|
|
|
orch._load_ci_watch_set = AsyncMock(return_value=watch)
|
2026-06-25 21:11:36 +02:00
|
|
|
db = MagicMock()
|
|
|
|
|
db.commit = AsyncMock()
|
|
|
|
|
engine = MagicMock()
|
|
|
|
|
engine.run_cycle = AsyncMock(return_value=[])
|
|
|
|
|
with (
|
|
|
|
|
patch("roboco.db.get_db_context", _db_ctx(db)),
|
|
|
|
|
patch(
|
|
|
|
|
"roboco.services.ci_watch_engine.get_ci_watch_engine",
|
|
|
|
|
return_value=engine,
|
|
|
|
|
) as get_eng,
|
|
|
|
|
):
|
|
|
|
|
await orch._run_ci_watch_cycle()
|
|
|
|
|
get_eng.assert_called_once()
|
|
|
|
|
engine.run_cycle.assert_awaited_once_with(watch)
|
|
|
|
|
db.commit.assert_awaited_once()
|