From 68cd89fbe1e46a723144ebfdf8c1a0fa247573e1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Th=C3=A9o=20LAGACHE?= <theo.lagache@soluce-technologies.com>
Date: Fri, 19 Jun 2026 15:49:46 +0200
Subject: [PATCH] =?UTF-8?q?fix(onboarding):=20address=20final=20review=20f?=
 =?UTF-8?q?indings=20=E2=80=94=20atomicity,=20scheduling=20guard,=20apply-?=
 =?UTF-8?q?all=20recovery,=20client=20validation?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .../actions/apply-db-settings.action.ts       | 55 ++++++++++---------
 .../onboarding/steps/step-db-settings.tsx     | 54 +++++++++++-------
 2 files changed, 65 insertions(+), 44 deletions(-)

diff --git a/src/features/onboarding/actions/apply-db-settings.action.ts b/src/features/onboarding/actions/apply-db-settings.action.ts
index 17a34184..7213d0bc 100644
--- a/src/features/onboarding/actions/apply-db-settings.action.ts
+++ b/src/features/onboarding/actions/apply-db-settings.action.ts
@@ -93,6 +93,7 @@ export const applyOnboardingDbSettingsAction = userAction
     };
 
     const applyScheduling = async () => {
+      if (backupMethod === undefined) return;
       // Direct DB update — intentionally skips the side effect in
       // updateDatabaseBackupPolicyAction that deletes retention policy on null.
       const cronValue =
@@ -105,37 +106,41 @@ export const applyOnboardingDbSettingsAction = userAction
 
     const applyNotifications = async () => {
       if (!notificationPolicies) return;
-      await db
-        .delete(drizzleDb.schemas.alertPolicy)
-        .where(eq(drizzleDb.schemas.alertPolicy.databaseId, databaseId));
+      await db.transaction(async (tx) => {
+        await tx
+          .delete(drizzleDb.schemas.alertPolicy)
+          .where(eq(drizzleDb.schemas.alertPolicy.databaseId, databaseId));
 
-      if (notificationPolicies.length > 0) {
-        await db.insert(drizzleDb.schemas.alertPolicy).values(
-          notificationPolicies.map((p) => ({
-            databaseId,
-            notificationChannelId: p.channelId,
-            eventKinds: p.eventKinds as any,
-            enabled: p.enabled,
-          }))
-        );
-      }
+        if (notificationPolicies.length > 0) {
+          await tx.insert(drizzleDb.schemas.alertPolicy).values(
+            notificationPolicies.map((p) => ({
+              databaseId,
+              notificationChannelId: p.channelId,
+              eventKinds: p.eventKinds as any,
+              enabled: p.enabled,
+            }))
+          );
+        }
+      });
     };
 
     const applyStorage = async () => {
       if (!storagePolicies) return;
-      await db
-        .delete(drizzleDb.schemas.storagePolicy)
-        .where(eq(drizzleDb.schemas.storagePolicy.databaseId, databaseId));
+      await db.transaction(async (tx) => {
+        await tx
+          .delete(drizzleDb.schemas.storagePolicy)
+          .where(eq(drizzleDb.schemas.storagePolicy.databaseId, databaseId));
 
-      if (storagePolicies.length > 0) {
-        await db.insert(drizzleDb.schemas.storagePolicy).values(
-          storagePolicies.map((p) => ({
-            databaseId,
-            storageChannelId: p.channelId,
-            enabled: p.enabled,
-          }))
-        );
-      }
+        if (storagePolicies.length > 0) {
+          await tx.insert(drizzleDb.schemas.storagePolicy).values(
+            storagePolicies.map((p) => ({
+              databaseId,
+              storageChannelId: p.channelId,
+              enabled: p.enabled,
+            }))
+          );
+        }
+      });
     };
 
     if (section === "retention" || section === "all") await applyRetention();
diff --git a/src/features/onboarding/steps/step-db-settings.tsx b/src/features/onboarding/steps/step-db-settings.tsx
index 60474711..5a72905c 100644
--- a/src/features/onboarding/steps/step-db-settings.tsx
+++ b/src/features/onboarding/steps/step-db-settings.tsx
@@ -497,7 +497,7 @@ const NotificationsSection = ({
         </Button>
         <Button
           type="button"
-          disabled={isPending}
+          disabled={isPending || policies.some((p) => !p.channelId || p.eventKinds.length === 0)}
           onClick={() => onSave(policies)}
           className="ml-auto"
         >
@@ -666,7 +666,7 @@ const StorageSection = ({
         </Button>
         <Button
           type="button"
-          disabled={isPending}
+          disabled={isPending || policies.some((p) => !p.channelId)}
           onClick={() => onSave(policies)}
           className="ml-auto"
         >
@@ -803,26 +803,42 @@ export const StepDbSettings = () => {
 
     const handleApplyToAll = async () => {
       const otherDbIds = databaseIds.filter((id) => id !== dbId);
+      const succeededIds: string[] = [];
+
       for (const targetId of otherDbIds) {
-        await applyMutation.mutateAsync({
-          databaseId: targetId,
-          section: "all",
-          retention: settings.retention,
-          backupMethod: settings.backupMethod,
-          backupCron: settings.backupCron,
-          notificationPolicies: settings.notificationPolicies as any,
-          storagePolicies: settings.storagePolicies,
+        try {
+          await applyMutation.mutateAsync({
+            databaseId: targetId,
+            section: "all",
+            retention: settings.retention,
+            backupMethod: settings.backupMethod,
+            backupCron: settings.backupCron,
+            notificationPolicies: settings.notificationPolicies,
+            storagePolicies: settings.storagePolicies,
+          });
+          succeededIds.push(targetId);
+        } catch {
+          // mutation onError already shows a toast
+        }
+      }
+
+      if (succeededIds.length > 0) {
+        const updatedSettings = { ...dbSettings };
+        succeededIds.forEach((id) => {
+          updatedSettings[id] = { ...(dbSettings[id] ?? {}), ...settings };
+        });
+        await updateContext({
+          flowData: { ...state?.context.flowData, dbSettings: updatedSettings },
         });
       }
-      const updatedSettings = { ...dbSettings };
-      otherDbIds.forEach((id) => {
-        updatedSettings[id] = { ...(dbSettings[id] ?? {}), ...settings };
-      });
-      await updateContext({
-        flowData: { ...state?.context.flowData, dbSettings: updatedSettings },
-      });
-      toast.success("Settings applied to all databases.");
-      setPhase({ kind: "grid" });
+
+      if (succeededIds.length === otherDbIds.length) {
+        toast.success("Settings applied to all databases.");
+        setPhase({ kind: "grid" });
+      } else if (succeededIds.length > 0) {
+        toast.warning(`Settings applied to ${succeededIds.length} of ${otherDbIds.length} databases.`);
+        setPhase({ kind: "grid" });
+      }
     };
 
     const SECTIONS: {