Files
pmg/cmd/sandbox/profile_show_test.go
T
b59c3358e8 fix(sandbox): classify helper-tool errors with usefulerror (#272)
* fix(sandbox): classify helper-tool errors with usefulerror

Sandbox helper commands (profile lint/diff/show/init/list) used to bubble
up plain fmt.Errorf chains from the registry layer, which the TUI then
classified as Unknown and decorated with a bug-report link. Wrap each
error path at the cmd/sandbox boundary so the TUI prints NotFound,
InvalidArgument, or PermissionDenied with actionable hints instead.

Closes #269

* refactor(sandbox): classify registry errors via sentinel wrapping

Replace the fragile substring match in profileLoadError with errors.Is
against new sandbox.ErrProfileNotFound / sandbox.ErrProfileInvalid
sentinels. Every fmt.Errorf in registry.go that previously communicated
"missing" or "malformed" by message text now wraps the corresponding
sentinel, so the cmd layer can classify without inspecting strings.

* fix(sandbox): detect IO error class when wrapping helper errors

Replace static ErrCodeUnknown / ErrCodePermissionDenied wrappings with
ioErrorCode, which inspects the error chain for fs.ErrPermission and
fs.ErrNotExist before falling back. Applied to runProfileList (where an
unreadable user profile directory now classifies as PermissionDenied),
registryInitError, and the stat/MkdirAll/WriteFile paths in profile init.

Also drop redundant doc comments on helpers whose names are self-evident.

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-05-21 19:34:29 +05:30

155 lines
4.4 KiB
Go

package sandbox
import (
"bytes"
"encoding/json"
"runtime"
"strings"
"testing"
"github.com/safedep/pmg/usefulerror"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestProfileShowRaw(t *testing.T) {
cmd := newProfileShowCommand(newTestRegistry(t, ""))
var stdout bytes.Buffer
cmd.SetOut(&stdout)
cmd.SetErr(&bytes.Buffer{})
cmd.SetArgs([]string{"npm-restrictive"})
require.NoError(t, cmd.Execute())
out := stdout.String()
assert.Contains(t, out, "name: npm-restrictive")
assert.Contains(t, out, "${CWD}", "raw output should preserve placeholders")
}
func TestProfileShowResolved(t *testing.T) {
cmd := newProfileShowCommand(newTestRegistry(t, ""))
var stdout bytes.Buffer
cmd.SetOut(&stdout)
cmd.SetErr(&bytes.Buffer{})
cmd.SetArgs([]string{"npm-restrictive", "--resolved", "--cwd", "/work", "--home", "/h"})
require.NoError(t, cmd.Execute())
out := stdout.String()
assert.NotContains(t, out, "${CWD}")
assert.NotContains(t, out, "${HOME}")
assert.Contains(t, out, "/work")
assert.Contains(t, out, "/h")
}
func TestProfileShowJSONRaw(t *testing.T) {
cmd := newProfileShowCommand(newTestRegistry(t, ""))
var stdout bytes.Buffer
cmd.SetOut(&stdout)
cmd.SetErr(&bytes.Buffer{})
cmd.SetArgs([]string{"npm-restrictive", "--json"})
require.NoError(t, cmd.Execute())
var report map[string]any
require.NoError(t, json.Unmarshal(stdout.Bytes(), &report))
assert.Equal(t, "npm-restrictive", report["name"])
assert.Equal(t, "builtin", report["source"])
assert.Contains(t, report["yaml"].(string), "name: npm-restrictive")
}
func TestProfileShowUnknownDriver(t *testing.T) {
cmd := newProfileShowCommand(newTestRegistry(t, ""))
var stdout, stderr bytes.Buffer
cmd.SetOut(&stdout)
cmd.SetErr(&stderr)
cmd.SetArgs([]string{"npm-restrictive", "--driver", "bogus"})
err := cmd.Execute()
require.Error(t, err)
assert.Empty(t, stderr.String())
assert.Contains(t, err.Error(), "unknown driver")
usefulErr, ok := usefulerror.AsUsefulError(err)
require.True(t, ok)
assert.Equal(t, usefulerror.ErrCodeInvalidArgument, usefulErr.Code())
}
func TestProfileShowUnknownProfileReturnsNotFound(t *testing.T) {
cmd := newProfileShowCommand(newTestRegistry(t, ""))
var stdout, stderr bytes.Buffer
cmd.SetOut(&stdout)
cmd.SetErr(&stderr)
cmd.SetArgs([]string{"does-not-exist"})
err := cmd.Execute()
require.Error(t, err)
assert.Empty(t, stdout.String())
assert.Empty(t, stderr.String())
assert.Contains(t, err.Error(), "not found")
usefulErr, ok := usefulerror.AsUsefulError(err)
require.True(t, ok)
assert.Equal(t, usefulerror.ErrCodeNotFound, usefulErr.Code())
}
func TestProfileShowMissingNameShowsUsage(t *testing.T) {
cmd := newProfileShowCommand(newTestRegistry(t, ""))
var stdout, stderr bytes.Buffer
cmd.SetOut(&stdout)
cmd.SetErr(&stderr)
cmd.SetArgs([]string{})
err := cmd.Execute()
require.Error(t, err)
assert.Contains(t, stderr.String(), "accepts 1 arg(s), received 0")
assert.Contains(t, stdout.String(), "Usage:")
assert.Contains(t, stdout.String(), "show <name> [flags]")
assert.Contains(t, stdout.String(), "pmg sandbox profile show npm-restrictive --resolved")
}
func TestProfileShowDriverNative(t *testing.T) {
cmd := newProfileShowCommand(newTestRegistry(t, ""))
var stdout bytes.Buffer
cmd.SetOut(&stdout)
cmd.SetErr(&bytes.Buffer{})
driver := ""
switch runtime.GOOS {
case "darwin":
driver = "seatbelt"
case "linux":
driver = "bubblewrap"
default:
t.Skipf("no native driver for %s", runtime.GOOS)
}
cmd.SetArgs([]string{"npm-restrictive", "--driver", driver})
require.NoError(t, cmd.Execute())
assert.NotEmpty(t, strings.TrimSpace(stdout.String()))
}
func TestProfileShowDriverNonNativeErrors(t *testing.T) {
cmd := newProfileShowCommand(newTestRegistry(t, ""))
var stdout, stderr bytes.Buffer
cmd.SetOut(&stdout)
cmd.SetErr(&stderr)
driver := ""
switch runtime.GOOS {
case "darwin":
driver = "bubblewrap"
case "linux":
driver = "seatbelt"
default:
t.Skipf("no non-native driver to test on %s", runtime.GOOS)
}
cmd.SetArgs([]string{"npm-restrictive", "--driver", driver})
err := cmd.Execute()
require.Error(t, err)
assert.Empty(t, stderr.String())
assert.Contains(t, err.Error(), "not available")
usefulErr, ok := usefulerror.AsUsefulError(err)
require.True(t, ok, "non-native driver error should be reported as a UsefulError")
assert.Equal(t, usefulerror.ErrCodeInvalidArgument, usefulErr.Code())
}