Files
pmg/internal/audit/cloud_sink_test.go
T
Sahilb315 748d40c14f fix: harden system dirs at install; keep sudo attribution without passwd
Address remaining review comments:

- shim: force root:root 0755 on the managed system dirs (shim tree and
  profile.d) after MkdirAll. A pre-created dir with weaker ownership,
  possible under Debian's group-writable /usr/local/lib, would let a
  non-root user replace the shims every account executes.

- audit: when SUDO_USER has no passwd entry (minimal containers),
  attribute cloud events from sudo's recorded SUDO_USER/SUDO_UID env
  instead of falling back to root. Still gated on euid 0.

- setup: reword the root-without---system warning; alias/shim install
  follows HOME, so claiming it configures only root's home was wrong.

- shim: skip the non-root-owner validation test on Windows, where file
  ownership is not resolvable.
2026-07-14 13:24:08 +05:30

197 lines
5.2 KiB
Go

package audit
import (
"context"
"os/user"
"testing"
"time"
servicev1 "buf.build/gen/go/safedep/api/protocolbuffers/go/safedep/services/controltower/v1"
"github.com/safedep/dry/cloud/endpointsync"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
type mockTransport struct {
requests []*servicev1.SyncEventsRequest
closed bool
}
func (m *mockTransport) Send(_ context.Context, req *servicev1.SyncEventsRequest) (*servicev1.SyncEventsResponse, error) {
m.requests = append(m.requests, req)
confirmed := make([]string, 0, len(req.GetEvents()))
for _, e := range req.GetEvents() {
confirmed = append(confirmed, e.GetEventId())
}
return &servicev1.SyncEventsResponse{ConfirmedEventIds: confirmed}, nil
}
func (m *mockTransport) Close() error {
m.closed = true
return nil
}
func newTestCloudSink(t *testing.T, transport endpointsync.EventTransport) *cloudSink {
t.Helper()
walPath := t.TempDir() + "/test-sync.db"
identity := endpointsync.NewEndpointIdentityResolver()
syncClient, err := endpointsync.NewSyncClient("pmg", "test", transport, identity,
endpointsync.WithWALPath(walPath))
require.NoError(t, err)
return &cloudSink{
SyncClientBundle: &SyncClientBundle{syncClient: syncClient},
invocationID: "test-invocation",
workingDir: t.TempDir(),
}
}
func TestCloudSinkEmitsTranslatableEvents(t *testing.T) {
transport := &mockTransport{}
sink := newTestCloudSink(t, transport)
defer func() {
require.NoError(t, sink.Close())
}()
err := sink.Handle(context.Background(), AuditEvent{
Type: EventTypeMalwareBlocked,
Timestamp: time.Now(),
Message: "blocked malware package",
})
assert.NoError(t, err)
}
func TestCloudSinkSkipsUntranslatableEvents(t *testing.T) {
transport := &mockTransport{}
sink := newTestCloudSink(t, transport)
defer func() {
require.NoError(t, sink.Close())
}()
err := sink.Handle(context.Background(), AuditEvent{
Type: EventTypeProxyHostObserved,
Timestamp: time.Now(),
Message: "observed proxy host",
Hostname: "example.com",
})
assert.NoError(t, err)
}
func TestCloudSinkEmitAndSync(t *testing.T) {
transport := &mockTransport{}
sink := newTestCloudSink(t, transport)
defer func() {
require.NoError(t, sink.Close())
}()
ctx := context.Background()
err := sink.Handle(ctx, AuditEvent{
Type: EventTypeMalwareBlocked,
Timestamp: time.Now(),
Message: "blocked malware package",
})
require.NoError(t, err)
synced, err := sink.syncClient.Sync(ctx)
require.NoError(t, err)
assert.Equal(t, 1, synced)
assert.Equal(t, 1, len(transport.requests))
}
func TestCloudSinkSetsInvocationContextOnSessionComplete(t *testing.T) {
transport := &mockTransport{}
sink := newTestCloudSink(t, transport)
defer func() {
require.NoError(t, sink.Close())
}()
ctx := context.Background()
err := sink.Handle(ctx, AuditEvent{
Type: EventTypeInstallStarted,
Timestamp: time.Now(),
PackageManager: "npm",
Args: []string{"install", "express"},
})
require.NoError(t, err)
err = sink.Handle(ctx, AuditEvent{
Type: EventTypeMalwareBlocked,
Timestamp: time.Now(),
Message: "blocked malware package",
})
require.NoError(t, err)
err = sink.Handle(ctx, AuditEvent{
Type: EventTypeSessionComplete,
Timestamp: time.Now(),
SessionData: &SessionData{
PackageManager: "npm",
FlowType: FlowTypeGuard,
Outcome: OutcomeSuccess,
TotalAnalyzed: 1,
AllowedCount: 1,
},
})
require.NoError(t, err)
synced, err := sink.syncClient.Sync(ctx)
require.NoError(t, err)
assert.Equal(t, 2, synced)
require.Equal(t, 1, len(transport.requests))
events := transport.requests[0].GetEvents()
require.Equal(t, 2, len(events))
malwareEvent := events[0]
assert.Nil(t, malwareEvent.GetInvocationContext(), "non-session events should not have invocation context")
sessionEvent := events[1]
invCtx := sessionEvent.GetInvocationContext()
require.NotNil(t, invCtx, "session complete event must have invocation context")
assert.Contains(t, invCtx.GetCommand(), "npm")
assert.NotEmpty(t, invCtx.GetWorkingDirectory())
assert.NotEmpty(t, invCtx.GetUsername())
assert.NotEmpty(t, invCtx.GetUsernameUid())
}
func TestInvokingUserIgnoresSudoUserWhenNotElevated(t *testing.T) {
current, err := user.Current()
require.NoError(t, err)
orig := auditGeteuid
t.Cleanup(func() { auditGeteuid = orig })
// Non-root process: SUDO_USER must be ignored, else attribution is spoofable.
auditGeteuid = func() int { return 1000 }
t.Setenv("SUDO_USER", "root")
got := invokingUser()
require.NotNil(t, got)
assert.Equal(t, current.Username, got.Username, "SUDO_USER must not override attribution when not elevated")
// Elevated (euid 0): SUDO_USER is trusted and used.
auditGeteuid = func() int { return 0 }
t.Setenv("SUDO_USER", current.Username)
got = invokingUser()
require.NotNil(t, got)
assert.Equal(t, current.Username, got.Username)
}
func TestInvokingUserKeepsSudoAttributionWithoutPasswdEntry(t *testing.T) {
orig := auditGeteuid
t.Cleanup(func() { auditGeteuid = orig })
auditGeteuid = func() int { return 0 }
t.Setenv("SUDO_USER", "no-such-user-xyz")
t.Setenv("SUDO_UID", "4242")
got := invokingUser()
require.NotNil(t, got)
assert.Equal(t, "no-such-user-xyz", got.Username)
assert.Equal(t, "4242", got.Uid)
}