mirror of
https://github.com/safedep/pmg.git
synced 2026-08-03 07:24:09 +02:00
* feat(sandbox): ExecutionContext plumbing and fail-closed lockdown contract
Network lockdown needs the PMG proxy's address, which is only known at
spawn time. Thread an ExecutionContext from the proxy flow through the
runner and executor into every sandbox driver, and enforce the
network_via_proxy_only fail-closed contract: lockdown without a running
loopback proxy, or on a driver that cannot enforce it, is a hard error —
never a silent fallback to unrestricted network.
- sandbox.ExecutionContext{ProxyAddr} + 4-arg Sandbox.Execute
- sandbox.ValidateLockdown validates the proxy address (loopback only)
with usefulerror code SandboxRequiresProxy
- Seatbelt validates lockdown before translation (translation itself
lands next); bubblewrap and landlock reject lockdown as unsupported
until Linux enforcement is implemented
- executor.WithExecutionContext, runner.ExecuteOptions.SandboxProxyAddr,
proxy flow passes the live proxy address
- ApplySandbox also validates centrally before invoking the driver
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqMU5GNBbQvQct9nxek1VS
* fix(sandbox): require numeric in-range proxy port in ValidateLockdown
The validated port string is embedded into generated sandbox profiles,
so service names, zero, and out-of-range ports are refused.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqMU5GNBbQvQct9nxek1VS
* fix(sandbox): fail closed on Seatbelt lockdown until translation lands
A lockdown policy that passed proxy validation would silently receive
the pre-lockdown network rules from the translator. Reject it until the
lockdown profile translation is implemented, keeping the window between
plumbing and enforcement fail-closed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqMU5GNBbQvQct9nxek1VS
* chore: review feedback — drop redundant comment, simplify stub help text
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqMU5GNBbQvQct9nxek1VS
---------
Co-authored-by: Claude <noreply@anthropic.com>
100 lines
2.3 KiB
Go
100 lines
2.3 KiB
Go
package sandbox
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/safedep/dry/utils"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestValidateNetworkLockdown(t *testing.T) {
|
|
lockdownPolicy := &SandboxPolicy{
|
|
Name: "lockdown",
|
|
NetworkViaProxyOnly: utils.PtrTo(true),
|
|
}
|
|
|
|
tests := []struct {
|
|
name string
|
|
policy *SandboxPolicy
|
|
rt *ExecutionContext
|
|
wantPort string
|
|
wantErr string
|
|
}{
|
|
{
|
|
name: "lockdown off returns empty port and no error",
|
|
policy: &SandboxPolicy{Name: "plain"},
|
|
rt: nil,
|
|
},
|
|
{
|
|
name: "nil execution context",
|
|
policy: lockdownPolicy,
|
|
rt: nil,
|
|
wantErr: "requires the PMG proxy",
|
|
},
|
|
{
|
|
name: "empty proxy address",
|
|
policy: lockdownPolicy,
|
|
rt: &ExecutionContext{},
|
|
wantErr: "requires the PMG proxy",
|
|
},
|
|
{
|
|
name: "non-loopback proxy address",
|
|
policy: lockdownPolicy,
|
|
rt: &ExecutionContext{ProxyAddr: "192.168.1.5:9999"},
|
|
wantErr: "loopback",
|
|
},
|
|
{
|
|
name: "unparseable proxy address",
|
|
policy: lockdownPolicy,
|
|
rt: &ExecutionContext{ProxyAddr: "not-an-address"},
|
|
wantErr: "loopback",
|
|
},
|
|
{
|
|
name: "service-name proxy port",
|
|
policy: lockdownPolicy,
|
|
rt: &ExecutionContext{ProxyAddr: "127.0.0.1:http"},
|
|
wantErr: "non-numeric or out-of-range proxy port",
|
|
},
|
|
{
|
|
name: "zero proxy port",
|
|
policy: lockdownPolicy,
|
|
rt: &ExecutionContext{ProxyAddr: "127.0.0.1:0"},
|
|
wantErr: "non-numeric or out-of-range proxy port",
|
|
},
|
|
{
|
|
name: "out-of-range proxy port",
|
|
policy: lockdownPolicy,
|
|
rt: &ExecutionContext{ProxyAddr: "127.0.0.1:70000"},
|
|
wantErr: "non-numeric or out-of-range proxy port",
|
|
},
|
|
{
|
|
name: "loopback ipv4 proxy address",
|
|
policy: lockdownPolicy,
|
|
rt: &ExecutionContext{ProxyAddr: "127.0.0.1:54321"},
|
|
wantPort: "54321",
|
|
},
|
|
{
|
|
name: "loopback ipv6 proxy address",
|
|
policy: lockdownPolicy,
|
|
rt: &ExecutionContext{ProxyAddr: "[::1]:54321"},
|
|
wantPort: "54321",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
port, err := ValidateNetworkLockdown(tt.policy, tt.rt)
|
|
|
|
if tt.wantErr != "" {
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), tt.wantErr)
|
|
return
|
|
}
|
|
|
|
require.NoError(t, err)
|
|
assert.Equal(t, tt.wantPort, port)
|
|
})
|
|
}
|
|
}
|