External/pmg
1
0
Fork 0
mirror of https://github.com/safedep/pmg.git synced 2026-08-03 07:24:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore: tune proxy config (#197)

Browse Source 
* chore: Increase PMG http server timeout

* chore: Tune upstream connection
This commit is contained in:
Abhisek Datta
2026-04-03 16:36:12 +05:30
committed by GitHub
parent 635e40cc1f
commit c7c4fc462f
3 changed files with 85 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
proxy/proxy_test.go
+43
View File
@@ -48,6 +48,49 @@ func TestNewProxyServerUpstreamTransportEnablesHTTP2(t *testing.T) {
assert.Equal(t, 200, tr.MaxIdleConns, "MaxIdleConns should accommodate multiple upstream registries")
}
func TestServerTimeoutSeparateFromRequestTimeout(t *testing.T) {
server, err := NewProxyServer(&ProxyConfig{
ListenAddr: "127.0.0.1:0",
EnableMITM: false,
ConnectTimeout: 30 * time.Second,
RequestTimeout: 5 * time.Minute,
ServerReadWriteTimeout: defaultServerReadWriteTimeout,
})
require.NoError(t, err)
ps, ok := server.(*proxyServer)
require.True(t, ok)
require.NoError(t, ps.Start())
defer func() { _ = ps.Stop(t.Context()) }()
// http.Server timeouts should use ServerReadWriteTimeout, not RequestTimeout
assert.Equal(t, defaultServerReadWriteTimeout, ps.server.ReadTimeout,
"server ReadTimeout should use ServerReadWriteTimeout to avoid deadline leaking into hijacked CONNECT tunnels")
assert.Equal(t, defaultServerReadWriteTimeout, ps.server.WriteTimeout,
"server WriteTimeout should use ServerReadWriteTimeout to avoid deadline leaking into hijacked CONNECT tunnels")
}
func TestServerTimeoutDefaultsWhenZero(t *testing.T) {
server, err := NewProxyServer(&ProxyConfig{
ListenAddr: "127.0.0.1:0",
EnableMITM: false,
ConnectTimeout: 30 * time.Second,
RequestTimeout: 5 * time.Minute,
// ServerReadWriteTimeout omitted (zero value)
})
require.NoError(t, err)
ps, ok := server.(*proxyServer)
require.True(t, ok)
require.NoError(t, ps.Start())
defer func() { _ = ps.Stop(t.Context()) }()
assert.Equal(t, defaultServerReadWriteTimeout, ps.server.ReadTimeout,
"server ReadTimeout should default to 30 minutes when ServerReadWriteTimeout is zero")
assert.Equal(t, defaultServerReadWriteTimeout, ps.server.WriteTimeout,
"server WriteTimeout should default to 30 minutes when ServerReadWriteTimeout is zero")
}
func TestNormalizeRequestURL(t *testing.T) {
tests := []struct {
name string