fix: Allow macos fsevents by default in sandbox (#244)

* fix: Allow macos fsevents by default in sandbox

* fix: Code review fixes
This commit is contained in:
Abhisek Datta
2026-05-07 12:32:38 +00:00
committed by GitHub
parent 4c42ceca0e
commit b671192598
2 changed files with 11 additions and 0 deletions
@@ -203,6 +203,7 @@ func (t *seatbeltPolicyTranslator) translate(policy *sandbox.SandboxPolicy) (str
sb.WriteString("(allow mach-lookup\n") sb.WriteString("(allow mach-lookup\n")
sb.WriteString(" (global-name \"com.apple.audio.systemsoundserver\")\n") sb.WriteString(" (global-name \"com.apple.audio.systemsoundserver\")\n")
sb.WriteString(" (global-name \"com.apple.distributed_notifications@Uv3\")\n") sb.WriteString(" (global-name \"com.apple.distributed_notifications@Uv3\")\n")
sb.WriteString(" (global-name \"com.apple.FSEvents\")\n")
sb.WriteString(" (global-name \"com.apple.FontObjectsServer\")\n") sb.WriteString(" (global-name \"com.apple.FontObjectsServer\")\n")
sb.WriteString(" (global-name \"com.apple.fonts\")\n") sb.WriteString(" (global-name \"com.apple.fonts\")\n")
sb.WriteString(" (global-name \"com.apple.logd\")\n") sb.WriteString(" (global-name \"com.apple.logd\")\n")
@@ -57,6 +57,16 @@ func TestSeatbeltTranslatorDarwinCommonTranslation(t *testing.T) {
assert.Contains(t, actual, "(allow process-fork)") assert.Contains(t, actual, "(allow process-fork)")
} }
func TestSeatbeltTranslatorDarwinAlwaysAllowsFSEventsMachLookup(t *testing.T) {
policy := &sandbox.SandboxPolicy{}
translator := newSeatbeltPolicyTranslator()
actual, err := translator.translate(policy)
require.NoError(t, err)
assert.Contains(t, actual, `(global-name "com.apple.FSEvents")`)
}
func TestSeatbeltTranslatorDarwinFilesystemTranslation(t *testing.T) { func TestSeatbeltTranslatorDarwinFilesystemTranslation(t *testing.T) {
cases := []struct { cases := []struct {
name string name string