fix: npm Dependency Cooldown Select Stable Version (#291)

* fix: npm Dependency Cooldown Select Stable Version * fix: Code review fixes
2026-08-03 07:24:09 +02:00 · 2026-05-25 14:38:39 +05:30
parent dc3f3e6618
commit 8cb7b7d1c0
4 changed files with 292 additions and 45 deletions
@@ -131,34 +131,72 @@ func TestCooldownOldestVersion(t *testing.T) {
 	})
 }

-func TestCooldownLatestEligibleVersion(t *testing.T) {
-	now := time.Now()
-	day := 24 * time.Hour
+func TestCooldownHighestStableVersion(t *testing.T) {
+	tests := []struct {
+		name       string
+		candidates []string
+		upperBound string
+		want       string
+	}{
+		{
+			name:       "highest stable by semver, not lexical",
+			candidates: []string{"0.9.0", "0.10.0", "0.2.0"},
+			want:       "0.10.0",
+		},
+		{
+			name:       "excludes prerelease and platform builds",
+			candidates: []string{"0.132.0", "0.132.5-win32-arm64", "0.133.0-alpha.3", "0.131.0"},
+			want:       "0.132.0",
+		},
+		{
+			name:       "no stable version returns empty",
+			candidates: []string{"1.0.0-alpha.1", "1.0.0-win32-arm64"},
+			want:       "",
+		},
+		{
+			name:       "unparseable versions skipped",
+			candidates: []string{"latest", "not-a-version", "1.2.3"},
+			want:       "1.2.3",
+		},
+		{
+			name:       "single stable",
+			candidates: []string{"2.0.0"},
+			want:       "2.0.0",
+		},
+		{
+			name:       "empty input",
+			candidates: []string{},
+			want:       "",
+		},
+		{
+			name:       "upper bound excludes higher major from another channel",
+			candidates: []string{"1.4.0", "2.0.0"},
+			upperBound: "1.5.0",
+			want:       "1.4.0",
+		},
+		{
+			name:       "upper bound allows versions at or below it",
+			candidates: []string{"1.4.0", "1.5.0", "2.0.0"},
+			upperBound: "1.5.0",
+			want:       "1.5.0",
+		},
+		{
+			name:       "unparseable upper bound applies no bound",
+			candidates: []string{"1.4.0", "2.0.0"},
+			upperBound: "not-a-version",
+			want:       "2.0.0",
+		},
+		{
+			name:       "prerelease upper bound does not exclude its stable counterpart",
+			candidates: []string{"1.0.0", "0.9.0"},
+			upperBound: "1.0.0-win32-arm64",
+			want:       "1.0.0",
+		},
+	}

-	t.Run("returns most recently published non-blocked version", func(t *testing.T) {
-		dates := map[string]time.Time{
-			"1.0.0": now.Add(-30 * day),
-			"2.0.0": now.Add(-10 * day),
-			"3.0.0": now.Add(-1 * day),
-		}
-		tooNew := map[string]bool{"3.0.0": true}
-		ver := cooldownLatestEligibleVersion(dates, tooNew)
-		assert.Equal(t, "2.0.0", ver)
-	})
-
-	t.Run("all versions blocked returns empty string", func(t *testing.T) {
-		dates := map[string]time.Time{"1.0.0": now, "2.0.0": now.Add(-1 * day)}
-		tooNew := map[string]bool{"1.0.0": true, "2.0.0": true}
-		ver := cooldownLatestEligibleVersion(dates, tooNew)
-		assert.Empty(t, ver)
-	})
-
-	t.Run("empty tooNew returns latest version", func(t *testing.T) {
-		dates := map[string]time.Time{
-			"1.0.0": now.Add(-30 * day),
-			"2.0.0": now.Add(-10 * day),
-		}
-		ver := cooldownLatestEligibleVersion(dates, map[string]bool{})
-		assert.Equal(t, "2.0.0", ver)
-	})
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equal(t, tt.want, cooldownHighestStableVersion(tt.candidates, tt.upperBound))
+		})
+	}
 }