mirror of
https://github.com/safedep/pmg.git
synced 2026-08-03 07:24:09 +02:00
Fix glob parent directory allowance for patterns with glob characters (#331)
* fix(sandbox): support pnpm workspaces and macOS cache dir in pnpm profile pnpm in a workspace (monorepo) creates a node_modules directory inside every workspace package to symlink direct dependencies. The profile only allowed writes to the root node_modules, so installs failed with EPERM on mkdir of e.g. apps/mobile/node_modules. pnpm on macOS also writes its cache (lockfile verification, metadata) under ~/Library/Caches/pnpm, while the base profile only covers the XDG path ~/.cache/pnpm. Fixes are scoped to the pnpm leaf profile, not the shared npm-restrictive base. Ref: https://github.com/safedep/pmg/issues/329 * fix(sandbox): emit regex parent rule for nested-glob allow patterns on Seatbelt For allow patterns ending in /**, the translator auto-allows the parent directory so mkdir/stat of the directory itself succeeds. The rule was always emitted as a literal, which can never match when the parent still contains glob characters (e.g. ${CWD}/**/node_modules from a workspace allowance) — silently leaving the directory's own creation denied. Emit a regex rule for glob-bearing parents instead. This stays strictly narrower than the Linux drivers (Bubblewrap binds the prefix before the first /** read-write; Landlock grants the glob expansion or its parent), and deny rules are emitted after allows, so mandatory credential denies still override. Ref: https://github.com/safedep/pmg/issues/329 --------- Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -107,6 +107,22 @@ func TestSeatbeltTranslatorDarwinFilesystemTranslation(t *testing.T) {
|
||||
assert.Contains(t, actual, "^/path/to/dir/.*$")
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "glob pattern with /** and glob parent",
|
||||
policy: &sandbox.SandboxPolicy{
|
||||
Filesystem: sandbox.FilesystemPolicy{
|
||||
AllowWrite: []string{"/project/**/node_modules/**"},
|
||||
},
|
||||
},
|
||||
assert: func(t *testing.T, actual string, err error) {
|
||||
assert.NoError(t, err)
|
||||
// Parent still contains a glob, so the auto-allow must be a
|
||||
// regex rule — a literal with ** can never match a real path.
|
||||
assert.Contains(t, actual, `(allow file-write* (regex #"^/project/(.*/)?node_modules$"))`)
|
||||
assert.Contains(t, actual, `^/project/(.*/)?node_modules/.*$`)
|
||||
assert.NotContains(t, actual, `(literal "/project/**/node_modules")`)
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "glob pattern with *.txt",
|
||||
policy: &sandbox.SandboxPolicy{
|
||||
|
||||
Reference in New Issue
Block a user