External/pmg
1
0
Fork 0
mirror of https://github.com/safedep/pmg.git synced 2026-08-03 07:24:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove script runners from NonDownloadCommands lists (#242)

Browse Source 
Script runners (run, start, stop, restart, test, etc.) are not
package management commands — remove them so they go through the
proxy instead of being skipped.
This commit is contained in:
Sahil Bansal
2026-05-06 21:13:03 +05:30
committed by GitHub
parent d8abfb6c41
commit 5122a1594c
3 changed files with 7 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packagemanager/npm_test.go
+7 -7
View File
@@ -539,26 +539,26 @@ func TestNpmProxyBehavior(t *testing.T) {
isKnownNonDownloadCmd: true,
isInstallationCommand: false,
},
// Script execution via run
// Script runners are not in NonDownloadCommands — proxy runs for them
{
name: "npm run dev — proxy skipped (executes local script, no registry contact)",
name: "npm run dev — proxy runs (script runner)",
pm: func() (*npmPackageManager, error) { return NewNpmPackageManager(DefaultNpmPackageManagerConfig()) },
command: "npm run dev",
isKnownNonDownloadCmd: true,
isKnownNonDownloadCmd: false,
isInstallationCommand: false,
},
{
name: "yarn run build — proxy skipped (executes local script)",
name: "yarn run build — proxy runs (script runner)",
pm: func() (*npmPackageManager, error) { return NewNpmPackageManager(DefaultYarnPackageManagerConfig()) },
command: "yarn run build",
isKnownNonDownloadCmd: true,
isKnownNonDownloadCmd: false,
isInstallationCommand: false,
},
{
name: "bun run test — proxy skipped (executes local script)",
name: "bun run test — proxy runs (script runner)",
pm: func() (*npmPackageManager, error) { return NewNpmPackageManager(DefaultBunPackageManagerConfig()) },
command: "bun run test",
isKnownNonDownloadCmd: true,
isKnownNonDownloadCmd: false,
isInstallationCommand: false,
},
// False positive regression: package/script names matching NonDownloadCommands words