External/pmg
1
0
Fork 0
mirror of https://github.com/safedep/pmg.git synced 2026-08-03 07:24:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove script runners from NonDownloadCommands lists (#242)

Browse Source 
Script runners (run, start, stop, restart, test, etc.) are not
package management commands — remove them so they go through the
proxy instead of being skipped.
This commit is contained in:
Sahil Bansal
2026-05-06 21:13:03 +05:30
committed by GitHub
parent d8abfb6c41
commit 5122a1594c
3 changed files with 7 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packagemanager/npm.go
-13
View File
@@ -21,16 +21,7 @@ func DefaultNpmPackageManagerConfig() NpmPackageManagerConfig {
InstallCommands: []string{"install", "i", "add"},
// Commands that are known to never download packages from a registry.
// Anything not in this list (including unknown future commands) runs with the proxy.
//
// Script runners: "run", "start", "stop", "restart", "test"/"t" are all shorthand for
// "npm run <script>". They spin up local processes (dev servers, test runners) that make
// their own HTTP calls — setting proxy env vars breaks them without providing any security
// benefit since they don't contact the package registry themselves.
//
// "exec" is intentionally excluded — it downloads and runs a package (npx equivalent).
NonDownloadCommands: []string{
// Script runners — may start servers or long-running processes
"run", "start", "stop", "restart", "test", "t",
// Removal — uninstalls local packages, no registry download
"uninstall", "remove", "rm", "r", "un", "unlink",
// Local operations — no registry contact
@@ -47,7 +38,6 @@ func DefaultPnpmPackageManagerConfig() NpmPackageManagerConfig {
return NpmPackageManagerConfig{
InstallCommands: []string{"install", "i", "add"},
NonDownloadCommands: []string{
"run", "start", "stop", "restart", "test",
"remove", "rm", "uninstall", "un",
"prune", "link", "unlink",
"ls", "list", "outdated", "info", "view", "config", "why",
@@ -60,8 +50,6 @@ func DefaultBunPackageManagerConfig() NpmPackageManagerConfig {
return NpmPackageManagerConfig{
InstallCommands: []string{"install", "i", "add"},
NonDownloadCommands: []string{
// Script runners and local operations
"run", "test", "build",
// Removal
"remove", "rm",
},
@@ -73,7 +61,6 @@ func DefaultYarnPackageManagerConfig() NpmPackageManagerConfig {
return NpmPackageManagerConfig{
InstallCommands: []string{"install", "add", ""},
NonDownloadCommands: []string{
"run", "start", "stop", "restart", "test",
"remove", "unlink",
"ls", "list", "outdated", "info", "config", "why",
},