External/pmg
1
0
Fork 0
mirror of https://github.com/safedep/pmg.git synced 2026-08-03 07:24:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix npm global flag usage (#166)

Browse Source 
* fix global flag usage

* add comment

* Update packagemanager/npm_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sahil Bansal <bansalsahil315@gmail.com>

* Update packagemanager/npm_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sahil Bansal <bansalsahil315@gmail.com>

---------

Signed-off-by: Sahil Bansal <bansalsahil315@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Sahil Bansal
2026-02-16 16:55:23 +05:30
committed by GitHub
co-authored by Copilot
parent 6074080219
commit 442a974aaa
2 changed files with 38 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packagemanager/npm_test.go
+35
View File
@@ -136,6 +136,41 @@ func TestNpmParseCommand(t *testing.T) {
assert.Equal(t, false, parsedCommand.IsManifestInstall) // with no package name, npm won’t add or install anything new
},
},
{
name: "npm install with global flag with single package",
command: "npm install -g prettier",
assert: func(t *testing.T, parsedCommand *ParsedCommand, err error) {
assert.NoError(t, err)
assert.Equal(t, 1, len(parsedCommand.InstallTargets))
assert.Equal(t, false, parsedCommand.IsManifestInstall)
assert.Equal(t, "prettier", parsedCommand.InstallTargets[0].PackageVersion.Package.Name)
},
},
{
name: "npm install with global flag with multiple packages",
command: "npm install -g prettier eslint",
assert: func(t *testing.T, parsedCommand *ParsedCommand, err error) {
assert.NoError(t, err)
assert.Equal(t, 2, len(parsedCommand.InstallTargets))
assert.Equal(t, false, parsedCommand.IsManifestInstall)
assert.Equal(t, "prettier", parsedCommand.InstallTargets[0].PackageVersion.Package.Name)
assert.Equal(t, "eslint", parsedCommand.InstallTargets[1].PackageVersion.Package.Name)
},
},
{
name: "npm install with global and dev flags with multiple packages",
command: "npm install -g --save-dev prettier eslint",
assert: func(t *testing.T, parsedCommand *ParsedCommand, err error) {
assert.NoError(t, err)
assert.Equal(t, 2, len(parsedCommand.InstallTargets))
assert.Equal(t, false, parsedCommand.IsManifestInstall)
var pkgs []string
for _, target := range parsedCommand.InstallTargets {
pkgs = append(pkgs, target.PackageVersion.Package.Name)
}
assert.ElementsMatch(t, []string{"prettier", "eslint"}, pkgs)
},
},
}
for _, tc := range cases {