refactor: Maintain single code path for package manager execution (#256)

* refactor: Maintain single code path for package manager execution * fix: Avoid context leak during interactive TTY read * fix: PTY flow handling * fix: Linter fixes
2026-08-03 07:24:09 +02:00 · 2026-05-13 19:14:00 +05:30
parent 511a6d1c58
commit 3848cc78e0
7 changed files with 581 additions and 261 deletions
@@ -0,0 +1,95 @@
+package runner
+
+import (
+	"context"
+	"os"
+	"testing"
+
+	"github.com/safedep/pmg/config"
+	"github.com/safedep/pmg/packagemanager"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestMergeEnvOverridesExistingValues(t *testing.T) {
+	env := mergeEnv(
+		[]string{
+			"PATH=/usr/bin",
+			"HTTP_PROXY=http://old-proxy",
+			"NO_PROXY=localhost",
+		},
+		[]string{
+			"HTTP_PROXY=http://pmg-proxy",
+			"HTTPS_PROXY=http://pmg-proxy",
+			"NO_PROXY=localhost,127.0.0.1",
+		},
+	)
+
+	assert.Equal(t, []string{
+		"PATH=/usr/bin",
+		"HTTP_PROXY=http://pmg-proxy",
+		"NO_PROXY=localhost,127.0.0.1",
+		"HTTPS_PROXY=http://pmg-proxy",
+	}, env)
+}
+
+func TestModeEnvOverrides(t *testing.T) {
+	opts := ExecuteOptions{
+		EnvOverrides:       []string{"HTTP_PROXY=http://pmg-proxy"},
+		DirectEnvOverrides: []string{"CI=true"},
+		PTYEnvOverrides:    []string{"TERM=xterm-256color"},
+	}
+
+	assert.Equal(t,
+		[]string{"HTTP_PROXY=http://pmg-proxy", "CI=true"},
+		modeEnvOverrides(opts, ExecutionModeDirect),
+	)
+
+	assert.Equal(t,
+		[]string{"HTTP_PROXY=http://pmg-proxy", "TERM=xterm-256color"},
+		modeEnvOverrides(opts, ExecutionModePTY),
+	)
+}
+
+func TestExecutionModeAuto(t *testing.T) {
+	assert.Equal(t, ExecutionModePTY, executionMode(ExecuteOptions{
+		Mode:          ExecutionModeAuto,
+		IsInteractive: func() bool { return true },
+	}))
+
+	assert.Equal(t, ExecutionModeDirect, executionMode(ExecuteOptions{
+		Mode:          ExecutionModeAuto,
+		IsInteractive: func() bool { return false },
+	}))
+}
+
+func TestExecuteWithOptionsRunsDirectHookBeforeSandbox(t *testing.T) {
+	cfg := config.Get()
+	previous := *cfg
+	t.Cleanup(func() {
+		*cfg = previous
+	})
+
+	cfg.Config.Sandbox.Enabled = true
+	cfg.Config.Sandbox.Policies = map[string]config.SandboxPolicyRef{}
+
+	exe, err := os.Executable()
+	require.NoError(t, err)
+
+	hookCalled := false
+	err = ExecuteWithOptions(context.Background(), &packagemanager.ParsedCommand{
+		Command: packagemanager.Command{
+			Exe: exe,
+		},
+	}, ExecuteOptions{
+		PackageManagerName: "npm",
+		Mode:               ExecutionModeDirect,
+		BeforeDirectRun: func() error {
+			hookCalled = true
+			return nil
+		},
+	})
+
+	require.Error(t, err)
+	assert.True(t, hookCalled)
+}