External/pmg
1
0
Fork 0
mirror of https://github.com/safedep/pmg.git synced 2026-08-03 07:24:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(npm): handle multiple packages and flag parsing correctly

Browse Source 
- Fixes issue where only the first package was scanned; now all packages in install command are parsed and processed.
- Correctly separates flags (e.g., --save-dev) from package names to avoid treating them as packages.
- Applies same fixes to both npm and pnpm flows.
- Updated wrapper to scan all packages before installing, maintaining original CLI behavior.
This commit is contained in:
Sahilb315
2025-05-11 22:47:16 +05:30
parent f7855e99a2
commit 361095182f
5 changed files with 142 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/npm/npm.go
+20 -3
View File
@@ -24,13 +24,30 @@ func NewNpmCommand() *cobra.Command {
}
if len(args) >= 2 && utils.IsInstallCommand(string(registry.RegistryNPM), args[0]) {
<<<<<<< HEAD
pmw := wrapper.NewPackageManagerWrapper(registry.RegistryNPM)
pmw.Action = args[0]
pmw.PackageName = args[1]
if err := pmw.Wrap(); err != nil {
os.Exit(1)
=======
if err := utils.ValidateEnvVars(); err != nil {
return err
}
// Parse arguments to separate flags and packages
flags, packages := utils.ParseNpmInstallArgs(args[1:])
>>>>>>> 5d0d78d (fix(npm): handle multiple packages and flag parsing correctly)
// If no packages specified, just pass through to npm
if len(packages) == 0 {
return utils.ExecCmd(execPath, args, []string{})
}
// Create single wrapper instance for all packages
pmw := wrapper.NewPackageManagerWrapper(registry.RegistryNPM, flags, packages, args[0])
if err := pmw.Wrap(); err != nil {
return err
}
return nil
}
cmd/npm/pnpm.go
+23 -5
View File
@@ -17,20 +17,38 @@ func NewPnpmCommand() *cobra.Command {
Short: "Scan packages from npm registry",
DisableFlagParsing: true,
RunE: func(cmd *cobra.Command, args []string) error {
execPath, err := utils.GetExecutablePath(string(registry.RegistryPNPM))
execPath, err := utils.GetExecutablePath(string(registry.RegistryNPM))
if err != nil {
fmt.Fprintf(os.Stderr, "pnpm not found: %v\n", err)
fmt.Fprintf(os.Stderr, "npm not found: %v\n", err)
return err
}
<<<<<<< HEAD
if len(args) >= 2 && utils.IsInstallCommand(string(registry.RegistryPNPM), args[0]) {
pmw := wrapper.NewPackageManagerWrapper(registry.RegistryPNPM)
pmw.Action = args[0]
pmw.PackageName = args[1]
if err := pmw.Wrap(); err != nil {
os.Exit(1)
=======
if len(args) >= 2 && utils.IsInstallCommand(string(registry.RegistryNPM), args[0]) {
if err := utils.ValidateEnvVars(); err != nil {
return err
}
// Parse arguments to separate flags and packages
flags, packages := utils.ParseNpmInstallArgs(args[1:])
>>>>>>> 5d0d78d (fix(npm): handle multiple packages and flag parsing correctly)
// If no packages specified, just pass through to npm
if len(packages) == 0 {
return utils.ExecCmd(execPath, args, []string{})
}
// Create single wrapper instance for all packages
pmw := wrapper.NewPackageManagerWrapper(registry.RegistryNPM, flags, packages, args[0])
if err := pmw.Wrap(); err != nil {
return err
}
return nil
}