refactor: move proxy block message rendering to presentation layer (#364)

* refactor: move proxy block message rendering to presentation layer * refactor: introduce ui.ProxyPresenter with injected advisory source * feat: friendly ecosystem labels in proxy block messages * test: cover ecosystemLabel derivation * fix: address review feedback on block context assertions and empty reference line
2026-08-03 07:24:09 +02:00 · 2026-07-10 17:42:26 +05:30
parent 2f1c348a06
commit 31e51b10dd
12 changed files with 358 additions and 97 deletions
@@ -0,0 +1,130 @@
+package ui
+
+import (
+	"testing"
+
+	packagev1 "buf.build/gen/go/safedep/api/protocolbuffers/go/safedep/messages/package/v1"
+	"github.com/safedep/pmg/proxy"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestEcosystemLabel(t *testing.T) {
+	tests := []struct {
+		ecosystem packagev1.Ecosystem
+		expected  string
+	}{
+		{packagev1.Ecosystem_ECOSYSTEM_NPM, "npm"},
+		{packagev1.Ecosystem_ECOSYSTEM_PYPI, "pypi"},
+		{packagev1.Ecosystem_ECOSYSTEM_GO, "go"},
+		{packagev1.Ecosystem_ECOSYSTEM_RUBYGEMS, "rubygems"},
+		{packagev1.Ecosystem_ECOSYSTEM_GITHUB_ACTIONS, "github_actions"},
+		{packagev1.Ecosystem_ECOSYSTEM_UNSPECIFIED, "unspecified"},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.expected, func(t *testing.T) {
+			assert.Equal(t, tt.expected, ecosystemLabel(tt.ecosystem))
+		})
+	}
+}
+
+func TestProxyPresenterBlockMessage(t *testing.T) {
+	malwareCtx := &proxy.BlockContext{
+		Ecosystem:           packagev1.Ecosystem_ECOSYSTEM_NPM,
+		PackageName:         "evil",
+		PackageVersion:      "1.0.0",
+		MalwareSummary:      "Contains known malware",
+		MalwareReferenceURL: "https://example.com/malware-report",
+	}
+
+	tests := []struct {
+		name     string
+		reason   proxy.BlockReason
+		blockCtx *proxy.BlockContext
+		advisory string
+		expected string
+	}{
+		{
+			name:     "malware",
+			reason:   proxy.BlockReasonMalware,
+			blockCtx: malwareCtx,
+			expected: "Malicious package blocked: npm/evil@1.0.0\n\nReason: Contains known malware\n\nReference: https://example.com/malware-report",
+		},
+		{
+			name:     "malware with advisory",
+			reason:   proxy.BlockReasonMalware,
+			blockCtx: malwareCtx,
+			advisory: "Contact #security-help",
+			expected: "Malicious package blocked: npm/evil@1.0.0\n\nReason: Contains known malware\n\nReference: https://example.com/malware-report\n\nContact #security-help",
+		},
+		{
+			name:     "user declined",
+			reason:   proxy.BlockReasonUserDeclined,
+			blockCtx: malwareCtx,
+			advisory: "Contact #security-help",
+			expected: "Installation blocked by user: npm/evil@1.0.0\n\nReason: Contains known malware\n\nReference: https://example.com/malware-report\n\nContact #security-help",
+		},
+		{
+			name:   "malware without reference URL omits reference line",
+			reason: proxy.BlockReasonMalware,
+			blockCtx: &proxy.BlockContext{
+				Ecosystem:      packagev1.Ecosystem_ECOSYSTEM_NPM,
+				PackageName:    "evil",
+				PackageVersion: "1.0.0",
+				MalwareSummary: "Contains known malware",
+			},
+			advisory: "Contact #security-help",
+			expected: "Malicious package blocked: npm/evil@1.0.0\n\nReason: Contains known malware\n\nContact #security-help",
+		},
+		{
+			name:     "confirmation failed carries no advisory",
+			reason:   proxy.BlockReasonConfirmationFailed,
+			blockCtx: malwareCtx,
+			advisory: "Contact #security-help",
+			expected: "Failed to get user confirmation for suspicious package npm/evil@1.0.0",
+		},
+		{
+			name:   "dependency cooldown",
+			reason: proxy.BlockReasonDependencyCooldown,
+			blockCtx: &proxy.BlockContext{
+				Ecosystem:        packagev1.Ecosystem_ECOSYSTEM_GO,
+				PackageName:      "example.com/fresh",
+				PackageVersion:   "v1.1.0",
+				CooldownDays:     7,
+				CooldownDaysAgo:  2,
+				CooldownDaysLeft: 5,
+			},
+			advisory: "Request an exemption at go/pmg-exceptions",
+			expected: "Package blocked by dependency cooldown: go/example.com/fresh@v1.1.0\n\nPublished 2 day(s) ago; cooldown window is 7 day(s) (5 remaining).\n\nRequest an exemption at go/pmg-exceptions",
+		},
+		{
+			name:     "nil context",
+			reason:   proxy.BlockReasonMalware,
+			blockCtx: nil,
+			expected: "",
+		},
+		{
+			name:     "no reason",
+			reason:   proxy.BlockReasonNone,
+			blockCtx: malwareCtx,
+			expected: "",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			p := ProxyPresenter{Advisory: func() string { return tt.advisory }}
+			assert.Equal(t, tt.expected, p.BlockMessage(tt.reason, tt.blockCtx))
+		})
+	}
+}
+
+func TestProxyPresenterNilAdvisory(t *testing.T) {
+	message := ProxyPresenter{}.BlockMessage(proxy.BlockReasonMalware, &proxy.BlockContext{
+		Ecosystem:      packagev1.Ecosystem_ECOSYSTEM_NPM,
+		PackageName:    "evil",
+		PackageVersion: "1.0.0",
+		MalwareSummary: "verified malware",
+	})
+	assert.Equal(t, "Malicious package blocked: npm/evil@1.0.0\n\nReason: verified malware", message)
+}