External/pmg
1
0
Fork 0
mirror of https://github.com/safedep/pmg.git synced 2026-08-03 07:24:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: Handle goproxy scheme handling bug (#181)

Browse Source 
* fix: Handle goproxy scheme handling bug

* fix: Code review fixes
This commit is contained in:
Abhisek Datta
2026-03-10 10:35:28 +05:30
committed by GitHub
parent f8fcdf6929
commit 2d1926388c
2 changed files with 163 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
proxy/proxy_test.go
+79
View File
@@ -4,6 +4,7 @@ import (
"crypto/tls"
"net/http"
"net/http/httptest"
"net/url"
"testing"
"time"
@@ -27,6 +28,84 @@ func TestNewProxyServerSecuresUpstreamTLSConfig(t *testing.T) {
assert.GreaterOrEqual(t, internalProxy.proxy.Tr.TLSClientConfig.MinVersion, uint16(tls.VersionTLS12), "minimum TLS version should be 1.2+")
}
func TestNormalizeRequestURL(t *testing.T) {
tests := []struct {
name string
inputURL string
expectedURL string
}{
{
name: "malformed URL with http embedded in https",
inputURL: "https://registry.npmjs.org:443http://registry.npmjs.org:443/-/npm/v1/security/advisories/bulk",
expectedURL: "https://registry.npmjs.org:443/-/npm/v1/security/advisories/bulk",
},
{
name: "malformed URL with http embedded for github packages",
inputURL: "https://npm.pkg.github.com:443http://npm.pkg.github.com:443/download/some_package/0.2.7-rc2/abc123",
expectedURL: "https://npm.pkg.github.com:443/download/some_package/0.2.7-rc2/abc123",
},
{
name: "normal https URL is unchanged",
inputURL: "https://registry.npmjs.org/-/npm/v1/security/advisories/bulk",
expectedURL: "https://registry.npmjs.org/-/npm/v1/security/advisories/bulk",
},
{
name: "normal http URL is unchanged",
inputURL: "http://registry.npmjs.org/-/npm/v1/security/advisories/bulk",
expectedURL: "http://registry.npmjs.org/-/npm/v1/security/advisories/bulk",
},
{
name: "URL with scoped package encoding",
inputURL: "https://npm.pkg.github.com:443http://npm.pkg.github.com:443/@scope%2fpackage",
expectedURL: "https://npm.pkg.github.com:443/@scope/package",
},
{
name: "URL with http in query parameter is unchanged",
inputURL: "https://example.com/api?redirect=http://foo.com",
expectedURL: "https://example.com/api?redirect=http://foo.com",
},
{
name: "URL with https in query parameter is unchanged",
inputURL: "https://example.com/api?url=https://bar.com/path",
expectedURL: "https://example.com/api?url=https://bar.com/path",
},
{
name: "URL with http in path segment is unchanged",
inputURL: "https://example.com/proxy/http://target.com/resource",
expectedURL: "https://example.com/proxy/http://target.com/resource",
},
{
name: "URL with http in fragment is unchanged",
inputURL: "https://example.com/docs#http://ref.com",
expectedURL: "https://example.com/docs#http://ref.com",
},
{
name: "malformed URL with query string preserved",
inputURL: "https://registry.npmjs.org:443http://registry.npmjs.org:443/-/npm/v1/security/advisories/bulk?foo=bar",
expectedURL: "https://registry.npmjs.org:443/-/npm/v1/security/advisories/bulk?foo=bar",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
parsed, err := url.Parse(tt.inputURL)
assert.NoError(t, err)
req := &http.Request{URL: parsed}
normalizeRequestURL(req)
assert.Equal(t, tt.expectedURL, req.URL.String())
})
}
}
func TestNormalizeRequestURLNilSafety(t *testing.T) {
// Should not panic
normalizeRequestURL(nil)
normalizeRequestURL(&http.Request{})
normalizeRequestURL(&http.Request{URL: &url.URL{}})
}
func TestNewProxyServerRejectsUntrustedUpstreamCertByDefault(t *testing.T) {
target := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusOK)