External/pmg
1
0
Fork 0
mirror of https://github.com/safedep/pmg.git synced 2026-08-03 07:24:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

perf: Use circuit breaker to fail open Malysis query requests (#196)

Browse Source 
* perf: Use circuit breaker to fail open Malysis query requests

* fix: Linter fixes

* test: Add test to confirm grpc status error unwrapping
This commit is contained in:
Abhisek Datta
2026-04-03 21:39:00 +05:30
committed by GitHub
parent c7c4fc462f
commit 115531f6b3
6 changed files with 262 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
proxy/interceptors/base_registry.go
+41 -3
View File
@@ -12,6 +12,9 @@ import (
"github.com/safedep/pmg/config"
"github.com/safedep/pmg/internal/eventlog"
"github.com/safedep/pmg/proxy"
gobreaker "github.com/sony/gobreaker/v2"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
)
// baseRegistryInterceptor provides common functionality for registry interceptors
@@ -21,6 +24,25 @@ type baseRegistryInterceptor struct {
cache AnalysisCache
statsCollector *AnalysisStatsCollector
confirmationChan chan *ConfirmationRequest
circuitBreaker *gobreaker.CircuitBreaker[*analyzer.PackageVersionAnalysisResult]
}
func newAnalyzerCircuitBreaker(name string) *gobreaker.CircuitBreaker[*analyzer.PackageVersionAnalysisResult] {
return newAnalyzerCircuitBreakerWithTimeout(name, 30*time.Second)
}
func newAnalyzerCircuitBreakerWithTimeout(name string, cooldown time.Duration) *gobreaker.CircuitBreaker[*analyzer.PackageVersionAnalysisResult] {
return gobreaker.NewCircuitBreaker[*analyzer.PackageVersionAnalysisResult](gobreaker.Settings{
Name: name,
MaxRequests: 1,
Timeout: cooldown,
ReadyToTrip: func(counts gobreaker.Counts) bool {
return counts.ConsecutiveFailures >= 3
},
OnStateChange: func(name string, from gobreaker.State, to gobreaker.State) {
log.Infof("Circuit breaker %s: %s -> %s", name, from, to)
},
})
}
var _ proxy.Interceptor = (*baseRegistryInterceptor)(nil)
@@ -87,10 +109,26 @@ func (b *baseRegistryInterceptor) analyzePackage(
log.Debugf("[%s] Analyzing package %s@%s", ctx.RequestID, packageName, packageVersion)
analysisCtx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()
result, err := b.circuitBreaker.Execute(func() (*analyzer.PackageVersionAnalysisResult, error) {
analysisCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
result, err := b.analyzer.Analyze(analysisCtx, pkgVersion)
res, err := b.analyzer.Analyze(analysisCtx, pkgVersion)
if err != nil {
// NotFound means the package is not in the analysis DB — this is expected
// and should not count as a circuit breaker failure.
// Since gRPC v1.75.0, status.FromError unwraps error chains via errors.As.
if s, ok := status.FromError(err); ok && s.Code() == codes.NotFound {
log.Debugf("[%s] Package %s@%s not found in analysis DB, allowing", ctx.RequestID, packageName, packageVersion)
return &analyzer.PackageVersionAnalysisResult{
PackageVersion: pkgVersion,
Action: analyzer.ActionAllow,
}, nil
}
}
return res, err
})
if err != nil {
return nil, fmt.Errorf("analyzer failed: %w", err)
}