fix: fail fast when package manager is not installed (#360)

* fix: fail fast with clear error when package manager is not installed

When PMG shims intercept a package manager that isn't installed (e.g. a
clean JAMF-provisioned laptop where PMG is set up before dev tooling),
real-binary resolution failed with a generic "unknown" error and a
bug-report link, making it look like PMG itself had crashed.

Introduce a typed BinaryNotFoundError that exits with code 127 (standard
"command not found") and maps to a new PackageManagerNotFound error code
with an actionable message instead of the Unknown classification.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: improve missing package manager help message

Use a concise, dynamic install hint instead of explaining PMG's
PATH forwarding internals.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: mention PATH in missing package manager help text

Covers the common case where a package manager is installed but its bin
directory is not on PATH yet (e.g. after curl | bash install).

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Sahil Bansal
2026-07-06 18:31:18 +05:30
committed by GitHub
co-authored by Cursor
parent b19473945b
commit 02965143d0
11 changed files with 124 additions and 0 deletions
+25
View File
@@ -3,9 +3,11 @@ package runner
import (
"context"
"os"
"path/filepath"
"testing"
"github.com/safedep/pmg/config"
"github.com/safedep/pmg/internal/shim"
"github.com/safedep/pmg/packagemanager"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
@@ -93,3 +95,26 @@ func TestExecuteWithOptionsRunsDirectHookBeforeSandbox(t *testing.T) {
require.Error(t, err)
assert.True(t, hookCalled)
}
func TestExecuteWithOptionsMissingPackageManager(t *testing.T) {
tmpDir := t.TempDir()
pmgBin := filepath.Join(tmpDir, ".pmg", "bin")
require.NoError(t, os.MkdirAll(pmgBin, 0o755))
require.NoError(t, os.WriteFile(filepath.Join(pmgBin, "bun"), []byte("#!/bin/sh\necho shim"), 0o755))
t.Setenv("PATH", pmgBin)
err := ExecuteWithOptions(context.Background(), &packagemanager.ParsedCommand{
Command: packagemanager.Command{
Exe: "bun",
Args: []string{"--version"},
},
}, ExecuteOptions{
PackageManagerName: "bun",
})
var notFound *shim.BinaryNotFoundError
require.ErrorAs(t, err, &notFound)
assert.Equal(t, "bun", notFound.Name)
assert.Equal(t, 127, notFound.ExitCode())
}