Update owasp2apache.py

- Error Handling: Added error handling for file operations, JSON parsing, and invalid rule structures. Logs warnings for invalid rules instead of crashing.
- Unique Rule IDs: Each rule is assigned a unique id to avoid collisions in ModSecurity.
- Path Handling: Used pathlib.Path for better path manipulation and readability.
- Logging: Replaced print() with Python's logging module for more flexible and structured logging.
- Input Validation: Added checks for missing keys in the input JSON file.
- Template for Rules: Used a template string (MODSEC_RULE_TEMPLATE) for consistent rule formatting.
- Output Directory Permissions: Ensured the output directory is created with parents=True to handle nested directories.

owasp2apache.py

@@ -1,46 +1,103 @@
 import json
 import os
 from collections import defaultdict
+import logging
+from pathlib import Path
+
+# Configure logging
+logging.basicConfig(
+    level=logging.INFO,
+    format="%(asctime)s - %(levelname)s - %(message)s",
+    handlers=[logging.StreamHandler()],
+)
 
 # Paths
-INPUT_FILE = "owasp_rules.json"
-OUTPUT_DIR = "waf_patterns/apache"
+INPUT_FILE = Path("owasp_rules.json")  # Input JSON file
+OUTPUT_DIR = Path("waf_patterns/apache")  # Output directory for Apache configs
 
 # Ensure output directory exists
-os.makedirs(OUTPUT_DIR, exist_ok=True)
+OUTPUT_DIR.mkdir(parents=True, exist_ok=True)
+
+# ModSecurity rule template
+MODSEC_RULE_TEMPLATE = (
+    'SecRule REQUEST_URI "{pattern}" "id:{rule_id},phase:1,deny,status:403,log,msg:\'{category} attack detected\'"\n'
+)
+
 
 def load_owasp_rules(file_path):
+    """
+    Load OWASP rules from a JSON file.
+    """
+    try:
         with open(file_path, "r") as f:
             return json.load(f)
+    except FileNotFoundError:
+        logging.error(f"[!] Input file not found: {file_path}")
+        raise
+    except json.JSONDecodeError:
+        logging.error(f"[!] Invalid JSON in file: {file_path}")
+        raise
+    except Exception as e:
+        logging.error(f"[!] Error loading OWASP rules: {e}")
+        raise
+
 
 def generate_apache_waf(rules):
+    """
+    Generate Apache ModSecurity configuration files from OWASP rules.
+    """
     categorized_rules = defaultdict(list)
+    rule_id_counter = 1000  # Starting rule ID
 
     # Group rules by category
     for rule in rules:
+        try:
             category = rule.get("category", "generic").lower()
-        categorized_rules[category].append(rule["pattern"])
+            pattern = rule["pattern"]
+            categorized_rules[category].append((pattern, rule_id_counter))
+            rule_id_counter += 1  # Increment rule ID to avoid collisions
+        except KeyError as e:
+            logging.warning(f"[!] Skipping invalid rule (missing key: {e}): {rule}")
+            continue
 
     # Convert to Apache conf files
     for category, patterns in categorized_rules.items():
-        output_file = os.path.join(OUTPUT_DIR, f"{category}.conf")
+        output_file = OUTPUT_DIR / f"{category}.conf"
 
+        try:
             with open(output_file, "w") as f:
                 f.write(f"# Apache ModSecurity rules for {category.upper()}\n")
-            f.write(f"SecRuleEngine On\n\n")
+                f.write("SecRuleEngine On\n\n")
 
                 # Write rules as ModSecurity SecRules
-            for pattern in patterns:
-                rule = f"SecRule REQUEST_URI \"{pattern}\" \"id:1000,phase:1,deny,status:403,log,msg:'{category} attack detected'\"\n"
+                for pattern, rule_id in patterns:
+                    rule = MODSEC_RULE_TEMPLATE.format(
+                        pattern=pattern, rule_id=rule_id, category=category
+                    )
                     f.write(rule)
 
-            print(f"[+] Generated {output_file} ({len(patterns)} patterns)")
+            logging.info(f"[+] Generated {output_file} ({len(patterns)} patterns)")
+        except IOError as e:
+            logging.error(f"[!] Failed to write to {output_file}: {e}")
+            raise
 
-if __name__ == "__main__":
-    print("[*] Loading OWASP rules...")
+
+def main():
+    """
+    Main function to execute the script.
+    """
+    try:
+        logging.info("[*] Loading OWASP rules...")
         owasp_rules = load_owasp_rules(INPUT_FILE)
 
-    print(f"[*] Generating Apache WAF configs from {len(owasp_rules)} rules...")
+        logging.info(f"[*] Generating Apache WAF configs from {len(owasp_rules)} rules...")
         generate_apache_waf(owasp_rules)
 
-    print("[✔] Apache ModSecurity configurations generated successfully.")
+        logging.info("[✔] Apache ModSecurity configurations generated successfully.")
+    except Exception as e:
+        logging.critical(f"[!] Script failed: {e}")
+        exit(1)
+
+
+if __name__ == "__main__":
+    main()