mirror of
https://github.com/nexu-io/open-design.git
synced 2026-10-27 09:51:12 +01:00
GoemonandGitHub
95bd7e5373
* fix(daemon): add required env field to McpServerStdio in live-artifacts MCP descriptor The ACP schema's McpServerStdio marks env as a required field (List[EnvVariable] with no default). Omitting it causes Pydantic V2 Union validation to fail across all three variants (HttpMcpServer, SseMcpServer, McpServerStdio), returning -32602 Invalid params on session/new for agents with mcpDiscovery: 'mature-acp' (Hermes, Devin, Kimi). This bug is invisible when mcpServers resolves to an empty array (no live-artifacts token), so it only manifests when the MCP live-artifacts integration is enabled. * fix(daemon): recover from -32602 Invalid params on session/set_model Extend the existing -32603 Internal error recovery logic to also handle -32602 (Invalid params) when the set_model request fails. This allows the prompt to proceed with the default model instead of hanging or timing out. Some ACP agents may not support session/set_model or may reject the model ID — treating this as a non-fatal condition and falling back to the default model is more resilient than failing the entire run. * fix(daemon): narrow -32602 handling and update test fixtures for env field Address PR #627 review feedback: 1. Narrow -32602 Invalid params suppression to setModelRequestId only. Unexpected-id -32602 errors are now treated as real protocol failures and propagated via fail(), matching the reviewer's suggestion. Only -32603 Internal errors from unexpected IDs are still suppressed as cleanup noise. 2. Update all buildLiveArtifactsMcpServersForAgent test fixtures to include the new required env: [] field.