mirror of
https://github.com/nexu-io/open-design.git
synced 2026-10-27 09:51:12 +01:00
Two coupled bugs surfaced when the daemon resolved an older `claude` binary on PATH: 1. Spawn crashed with "unknown option '--include-partial-messages'" because that flag landed in 1.0.86 and we passed it unconditionally. 2. Even after dropping the flag, the assistant bubble rendered empty — the stream parser only extracted text from `stream_event` deltas (only emitted under --include-partial-messages). Without those events, the full text in the `assistant` wrapper went unread. Fix: - Probe `claude --help` once during agent detection and cache which flags the installed CLI advertises (`agentCapabilities` map). - `buildArgs` reads the cache and only emits `--include-partial-messages` / `--add-dir` when supported; safe baseline when probing fails. - Warm the cache on server startup (`detectAgents()`) so the first /api/chat doesn't race ahead of the frontend's /api/agents call. - Parse text (and thinking) blocks out of the `assistant` wrapper as a fallback, deduped via a per-message-id `textStreamed` set so newer builds streaming deltas never double-emit. Co-authored-by: lukebaze <lukebaze@users.noreply.github.com> Co-authored-by: lefarcen <20859779+lefarcen@users.noreply.github.com>
218 lines
7.1 KiB
JavaScript
218 lines
7.1 KiB
JavaScript
/**
|
|
* Parses Claude Code's `--output-format stream-json --verbose` JSONL stream
|
|
* (with or without `--include-partial-messages`) into a small set of
|
|
* UI-friendly events. With partial messages on, text arrives as
|
|
* `stream_event` deltas; without it (older builds <1.0.86, or any build
|
|
* where the flag isn't passed) text arrives only in the final `assistant`
|
|
* wrapper. We handle both. The UI only needs to know five things:
|
|
*
|
|
* - status : high-level lifecycle ("initializing", "requesting",
|
|
* "thinking")
|
|
* - text_delta : assistant text chunk (gets fed to the artifact parser)
|
|
* - thinking_delta: extended-thinking chunk (shown in a collapsed block)
|
|
* - tool_use : { id, name, input } (fires when input is complete)
|
|
* - tool_result : { tool_use_id, content, is_error }
|
|
* - usage : aggregated input/output/cache tokens + cost
|
|
*
|
|
* Callers give us `onEvent({ type, ...payload })`. We track per-content-block
|
|
* state to accumulate partial tool_use input JSON and emit a single
|
|
* `tool_use` event when that block stops.
|
|
*/
|
|
|
|
export function createClaudeStreamHandler(onEvent) {
|
|
let buffer = '';
|
|
|
|
// Per-content-block scratch, keyed by `${messageId}:${blockIndex}`.
|
|
const blocks = new Map();
|
|
// Most recent assistant message id so content_block_* events without an id
|
|
// can be attributed correctly.
|
|
let currentMessageId = null;
|
|
// Message ids that already streamed text via `stream_event` deltas.
|
|
// When `--include-partial-messages` is OFF (older Claude Code, e.g. 1.0.84
|
|
// pre-flag), no deltas arrive — only the final `assistant` wrapper carries
|
|
// text. The fallback below emits that text once, but we must skip it for
|
|
// newer builds that already streamed deltas, otherwise the message would
|
|
// duplicate.
|
|
const textStreamed = new Set();
|
|
|
|
function blockKey(index) {
|
|
return `${currentMessageId ?? 'anon'}:${index}`;
|
|
}
|
|
|
|
function feed(chunk) {
|
|
buffer += chunk;
|
|
let nl;
|
|
while ((nl = buffer.indexOf('\n')) !== -1) {
|
|
const line = buffer.slice(0, nl).trim();
|
|
buffer = buffer.slice(nl + 1);
|
|
if (!line) continue;
|
|
let obj;
|
|
try {
|
|
obj = JSON.parse(line);
|
|
} catch {
|
|
onEvent({ type: 'raw', line });
|
|
continue;
|
|
}
|
|
handleObject(obj);
|
|
}
|
|
}
|
|
|
|
function flush() {
|
|
const rem = buffer.trim();
|
|
buffer = '';
|
|
if (!rem) return;
|
|
try {
|
|
handleObject(JSON.parse(rem));
|
|
} catch {
|
|
onEvent({ type: 'raw', line: rem });
|
|
}
|
|
}
|
|
|
|
function handleObject(obj) {
|
|
if (!obj || typeof obj !== 'object') return;
|
|
|
|
if (obj.type === 'system' && obj.subtype === 'init') {
|
|
onEvent({
|
|
type: 'status',
|
|
label: 'initializing',
|
|
model: obj.model ?? null,
|
|
sessionId: obj.session_id ?? null,
|
|
});
|
|
return;
|
|
}
|
|
|
|
if (obj.type === 'system' && obj.subtype === 'status') {
|
|
onEvent({ type: 'status', label: obj.status ?? 'working' });
|
|
return;
|
|
}
|
|
|
|
if (obj.type === 'stream_event' && obj.event) {
|
|
handleStreamEvent(obj.event);
|
|
return;
|
|
}
|
|
|
|
// `assistant` messages are the "block finished" signal for the current
|
|
// content block. For tool_use blocks whose input finished assembling,
|
|
// emit tool_use now with the final parsed input. For text blocks, emit
|
|
// the text as a single delta — but only if no streaming deltas already
|
|
// covered it (older Claude Code without --include-partial-messages
|
|
// delivers text only here; newer builds stream it and would duplicate).
|
|
if (obj.type === 'assistant' && obj.message?.content) {
|
|
currentMessageId = obj.message.id ?? currentMessageId;
|
|
const msgId = obj.message.id ?? null;
|
|
const alreadyStreamed = msgId ? textStreamed.has(msgId) : false;
|
|
for (const block of obj.message.content) {
|
|
if (block.type === 'tool_use') {
|
|
onEvent({
|
|
type: 'tool_use',
|
|
id: block.id,
|
|
name: block.name,
|
|
input: block.input ?? null,
|
|
});
|
|
} else if (
|
|
!alreadyStreamed &&
|
|
block.type === 'text' &&
|
|
typeof block.text === 'string' &&
|
|
block.text.length > 0
|
|
) {
|
|
onEvent({ type: 'text_delta', delta: block.text });
|
|
} else if (
|
|
!alreadyStreamed &&
|
|
block.type === 'thinking' &&
|
|
typeof block.thinking === 'string' &&
|
|
block.thinking.length > 0
|
|
) {
|
|
onEvent({ type: 'thinking_delta', delta: block.thinking });
|
|
}
|
|
}
|
|
return;
|
|
}
|
|
|
|
// `user` messages in a stream-json transcript are usually tool_result
|
|
// wrappers from prior turns.
|
|
if (obj.type === 'user' && obj.message?.content) {
|
|
for (const block of obj.message.content) {
|
|
if (block.type === 'tool_result') {
|
|
onEvent({
|
|
type: 'tool_result',
|
|
toolUseId: block.tool_use_id,
|
|
content: stringifyToolResult(block.content),
|
|
isError: Boolean(block.is_error),
|
|
});
|
|
}
|
|
}
|
|
return;
|
|
}
|
|
|
|
if (obj.type === 'result') {
|
|
onEvent({
|
|
type: 'usage',
|
|
usage: obj.usage ?? null,
|
|
costUsd: obj.total_cost_usd ?? null,
|
|
durationMs: obj.duration_ms ?? null,
|
|
stopReason: obj.stop_reason ?? null,
|
|
});
|
|
return;
|
|
}
|
|
}
|
|
|
|
function handleStreamEvent(ev) {
|
|
if (ev.type === 'message_start') {
|
|
currentMessageId = ev.message?.id ?? null;
|
|
if (typeof ev.ttft_ms === 'number') {
|
|
onEvent({ type: 'status', label: 'streaming', ttftMs: ev.ttft_ms });
|
|
}
|
|
return;
|
|
}
|
|
|
|
if (ev.type === 'content_block_start' && ev.content_block) {
|
|
const key = blockKey(ev.index);
|
|
const block = ev.content_block;
|
|
blocks.set(key, { type: block.type, name: block.name, id: block.id, input: '' });
|
|
if (block.type === 'thinking') {
|
|
onEvent({ type: 'thinking_start' });
|
|
}
|
|
return;
|
|
}
|
|
|
|
if (ev.type === 'content_block_delta' && ev.delta) {
|
|
const state = blocks.get(blockKey(ev.index));
|
|
const delta = ev.delta;
|
|
|
|
if (delta.type === 'text_delta' && typeof delta.text === 'string') {
|
|
if (currentMessageId) textStreamed.add(currentMessageId);
|
|
onEvent({ type: 'text_delta', delta: delta.text });
|
|
return;
|
|
}
|
|
if (delta.type === 'thinking_delta' && typeof delta.thinking === 'string') {
|
|
if (currentMessageId) textStreamed.add(currentMessageId);
|
|
onEvent({ type: 'thinking_delta', delta: delta.thinking });
|
|
return;
|
|
}
|
|
if (delta.type === 'input_json_delta' && typeof delta.partial_json === 'string') {
|
|
if (state && state.type === 'tool_use') {
|
|
state.input += delta.partial_json;
|
|
}
|
|
return;
|
|
}
|
|
}
|
|
|
|
if (ev.type === 'content_block_stop') {
|
|
blocks.delete(blockKey(ev.index));
|
|
return;
|
|
}
|
|
}
|
|
|
|
return { feed, flush };
|
|
}
|
|
|
|
function stringifyToolResult(content) {
|
|
if (typeof content === 'string') return content;
|
|
if (Array.isArray(content)) {
|
|
return content
|
|
.map((c) => (c?.type === 'text' ? c.text : JSON.stringify(c)))
|
|
.join('\n');
|
|
}
|
|
return JSON.stringify(content);
|
|
}
|