mirror of
https://github.com/rzuasti/oott.git
synced 2026-07-08 19:21:54 +02:00
rzuastiandClaude Opus 4.8
4f3fe10332
Backend (Rust): - push_tokens migration, model (PushToken/PushPlatform), and db layer (upsert/list/delete/delete_many) - PUT/DELETE /api/push_tokens endpoints wired into the router + OpenAPI - "push" notification method: relay sender (reqwest) that forwards only the sanitized title/body and prunes dead tokens, plus settings with a default relay_url - 164 tests pass, clippy clean Relay (push_relay/, TypeScript Firebase Cloud Function): - POST /v1/push (firebase-admin sendEach + per-token status mapping), GET /healthz, payload validation, per-IP Firestore rate limiting - Jest tests + README documenting the manual project-owned setup Frontend (Flutter): - oott_api_push.dart (register/unregister), push_service.dart behind a PushService abstraction, and a per-device push toggle in settings - firebase_core/firebase_messaging/flutter_local_notifications deps - 145 tests pass, dart analyze clean Dev shell: - add nodejs_22 to the Nix dev shell so the relay tests/build run locally Remaining (manual, project-owned): create the Firebase project, deploy the relay and set the real default_relay_url, add native Firebase config, and test on real devices. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
68 lines
2.3 KiB
TypeScript
68 lines
2.3 KiB
TypeScript
import express, { type Express, type Request, type Response } from "express";
|
|
|
|
import { sendPush, validatePushRequest, type MessengerLike } from "./push";
|
|
import {
|
|
checkRateLimit,
|
|
DEFAULT_RATE_LIMIT,
|
|
type RateLimitOptions,
|
|
type RateLimitStore,
|
|
} from "./rateLimit";
|
|
|
|
export interface AppDependencies {
|
|
messenger: MessengerLike;
|
|
rateLimitStore: RateLimitStore;
|
|
rateLimit?: RateLimitOptions;
|
|
}
|
|
|
|
// Identify the caller for rate limiting. Behind Cloud Functions the real client IP is the left-most
|
|
// entry of X-Forwarded-For (Google's proxy appends its own); `trust proxy` makes `req.ip` resolve to
|
|
// it. One home/deployment is roughly one public IP.
|
|
function clientKey(req: Request): string {
|
|
return req.ip ?? "unknown";
|
|
}
|
|
|
|
// Build the relay HTTP app. Dependencies are injected so the routes can be exercised with a fake
|
|
// messenger and an in-memory rate-limit store in tests, and with the real Firebase ones in
|
|
// production (see index.ts).
|
|
export function createApp(deps: AppDependencies): Express {
|
|
const app = express();
|
|
// Trust Google's front-end proxy so req.ip is the caller, not the proxy.
|
|
app.set("trust proxy", true);
|
|
app.use(express.json({ limit: "256kb" }));
|
|
|
|
// Liveness probe — no side effects, never rate limited.
|
|
app.get("/healthz", (_req: Request, res: Response) => {
|
|
res.status(200).send("ok");
|
|
});
|
|
|
|
app.post("/v1/push", async (req: Request, res: Response) => {
|
|
try {
|
|
const decision = await checkRateLimit(
|
|
deps.rateLimitStore,
|
|
clientKey(req),
|
|
deps.rateLimit ?? DEFAULT_RATE_LIMIT,
|
|
);
|
|
if (!decision.allowed) {
|
|
res.status(429).json({ error: "rate limit exceeded" });
|
|
return;
|
|
}
|
|
|
|
const validation = validatePushRequest(req.body);
|
|
if (!validation.ok) {
|
|
res.status(400).json({ error: validation.error });
|
|
return;
|
|
}
|
|
|
|
const results = await sendPush(deps.messenger, validation.value);
|
|
res.status(200).json({ results });
|
|
} catch (err) {
|
|
// A messenger/transport failure is upstream's fault, not the caller's.
|
|
const message = err instanceof Error ? err.message : "unknown error";
|
|
console.error("Failed to relay push:", message);
|
|
res.status(502).json({ error: "failed to deliver to FCM" });
|
|
}
|
|
});
|
|
|
|
return app;
|
|
}
|