Files
oott/frontend/test/widget/device_actions_test.dart
T
rzuastiandClaude Opus 4.8 587e097291 Add permanent device deletion and refine frontend UI/snackbars
Backend:
- Add db::devices::delete to erase a device and its events atomically
- Expose DELETE /api/devices/{mac}/permanently, wired to OpenAPI
- Cover the new db method and endpoint with tests

Frontend:
- Delete action for not-registered devices (detail screen + list row)
  and an opt-in "permanently delete" checkbox in the Forget dialog
- Navigate to the devices list after deleting from the detail screen
- Refine button emphasis to M3: single filled primary, error-colored
  text buttons for destructive actions, Test demoted to filled-tonal
- Flash the backend-config Test button red on a failed connection test
- Render snackbars through a top-level ScaffoldMessenger host so they
  show above dialogs; keep the built-in SnackBar (with an Overlay host)

Docs:
- CLAUDE.md: rustfmt edition 2024, don't revert formatter-only changes,
  prefer built-in Flutter components, follow existing patterns + M3

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-12 09:49:11 -04:00

171 lines
4.9 KiB
Dart

import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:frontend/devices/device_list.dart';
import 'package:http_mock_adapter/http_mock_adapter.dart';
import '../helpers/backend_test_harness.dart';
import '../helpers/fixtures.dart';
import '../helpers/pump_app.dart';
void main() {
late DioAdapter adapter;
setUp(() async {
adapter = await setUpBackendForTest();
});
Future<void> openRowMenu(WidgetTester tester) async {
await tester.tap(find.byIcon(Icons.more_vert).first);
await tester.pumpAndSettle();
}
testWidgets(
'deleting a not-registered device from the list calls the delete endpoint',
(tester) async {
adapter.onGet(
'/devices',
(server) => server.reply(
200,
pagedListJson([
deviceJson(macAddress: 'aa:bb:cc:dd:ee:01', isRegistered: false),
]),
),
);
var deleteCalled = false;
adapter.onDelete('/devices/aa:bb:cc:dd:ee:01/permanently', (server) {
deleteCalled = true;
server.reply(200, null);
});
await pumpScreen(tester, const DeviceList());
await pumpUntilFound(tester, find.byIcon(Icons.more_vert));
await openRowMenu(tester);
expect(find.text('Delete'), findsOneWidget);
await tester.tap(find.text('Delete'));
await tester.pumpAndSettle();
// The confirmation dialog warns the deletion is permanent.
expect(find.textContaining('cannot be undone'), findsOneWidget);
await tester.tap(find.widgetWithText(TextButton, 'Delete'));
await tester.pumpAndSettle();
expect(deleteCalled, isTrue);
expect(find.text('Device deleted'), findsOneWidget);
await tearDownTree(tester);
},
);
testWidgets('not-registered devices do not expose Forget', (tester) async {
adapter.onGet(
'/devices',
(server) => server.reply(
200,
pagedListJson([
deviceJson(macAddress: 'aa:bb:cc:dd:ee:02', isRegistered: false),
]),
),
);
await pumpScreen(tester, const DeviceList());
await pumpUntilFound(tester, find.byIcon(Icons.more_vert));
await openRowMenu(tester);
expect(find.text('Forget'), findsNothing);
expect(find.text('Delete'), findsOneWidget);
await tearDownTree(tester);
});
testWidgets(
'forget dialog deletes the device when the also-delete box is ticked',
(tester) async {
adapter.onGet(
'/devices',
(server) => server.reply(
200,
pagedListJson([
deviceJson(
macAddress: 'aa:bb:cc:dd:ee:03',
isRegistered: true,
owner: 'alice',
),
]),
),
);
var deleteCalled = false;
// Only the permanent-delete route is mocked: had the dialog taken the
// plain "forget" path instead, the unmocked DELETE would surface an error
// snackbar rather than the success one asserted below.
adapter.onDelete('/devices/aa:bb:cc:dd:ee:03/permanently', (server) {
deleteCalled = true;
server.reply(200, null);
});
await pumpScreen(tester, const DeviceList());
await pumpUntilFound(tester, find.byIcon(Icons.more_vert));
await openRowMenu(tester);
await tester.tap(find.text('Forget'));
await tester.pumpAndSettle();
// Checkbox is unchecked by default, so no warning is shown yet.
expect(find.textContaining('cannot be undone'), findsNothing);
await tester.tap(find.byType(CheckboxListTile));
await tester.pumpAndSettle();
// Ticking it reveals the permanent-deletion warning.
expect(find.textContaining('cannot be undone'), findsOneWidget);
await tester.tap(find.widgetWithText(TextButton, 'Delete'));
await tester.pumpAndSettle();
expect(deleteCalled, isTrue);
expect(find.text('Device deleted'), findsOneWidget);
await tearDownTree(tester);
},
);
testWidgets('forget dialog unregisters when the box is left unticked', (
tester,
) async {
adapter.onGet(
'/devices',
(server) => server.reply(
200,
pagedListJson([
deviceJson(
macAddress: 'aa:bb:cc:dd:ee:04',
isRegistered: true,
owner: 'bob',
),
]),
),
);
var forgetCalled = false;
adapter.onDelete('/devices/aa:bb:cc:dd:ee:04', (server) {
forgetCalled = true;
server.reply(200, null);
});
await pumpScreen(tester, const DeviceList());
await pumpUntilFound(tester, find.byIcon(Icons.more_vert));
await openRowMenu(tester);
await tester.tap(find.text('Forget'));
await tester.pumpAndSettle();
await tester.tap(find.widgetWithText(TextButton, 'Forget'));
await tester.pumpAndSettle();
expect(forgetCalled, isTrue);
expect(find.text('Device forgotten'), findsOneWidget);
await tearDownTree(tester);
});
}