External/oott
1
0
Fork 0
mirror of https://github.com/rzuasti/oott.git synced 2026-07-08 19:21:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

Display unknown values as a dash and centralise repeated literals

Browse Source 
Backend: notifications now show a plain "-" for an absent name, vendor, or
device type (was empty string / "(unknown)" / "Unknown"), via a single
UNKNOWN_PLACEHOLDER constant.

Frontend:
- Empty/unknown values render as an em dash everywhere, centralised in a new
  Placeholders.emptyValue constant (replaces inline '—' and '(unknown)').
- Route paths moved to a new Routes class, used by the router and every
  navigation call site.
- Device event type modelled as a DeviceEventType enum mirroring the backend
  (NewDevice/DeviceSeen) instead of bare string comparisons.
- Hardcoded EdgeInsets/SizedBox spacing replaced with existing Insets tokens.

Tests and formatting updated; all backend and frontend tests pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
rzuasti
2026-06-06 16:07:05 -04:00
co-authored by Claude Opus 4.8
parent cf8979f63d
commit a51b9c06dc
32 changed files with 295 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/test/unit/polled_value_test.dart
+23 -21
View File
@@ -32,9 +32,9 @@ void main() {
}
DioException connectionError() => DioException(
requestOptions: RequestOptions(path: '/x'),
type: DioExceptionType.connectionError,
);
requestOptions: RequestOptions(path: '/x'),
type: DioExceptionType.connectionError,
);
test('starts in initialLoading then becomes fresh on success', () async {
final polled = makePolled();
@@ -62,28 +62,30 @@ void main() {
expect(polled.lastErrorMessage, isNotNull);
});
test('a failure after a success is stale, then error past staleErrorAfter',
() async {
final polled = makePolled(staleErrorAfter: const Duration(seconds: 1));
addTearDown(polled.dispose);
test(
'a failure after a success is stale, then error past staleErrorAfter',
() async {
final polled = makePolled(staleErrorAfter: const Duration(seconds: 1));
addTearDown(polled.dispose);
completers[0].complete(1);
await pumpEventQueue();
expect(polled.freshness, PolledFreshness.fresh);
completers[0].complete(1);
await pumpEventQueue();
expect(polled.freshness, PolledFreshness.fresh);
// Force a second load and fail it.
polled.pause();
polled.resume();
await pumpEventQueue();
completers[1].completeError(connectionError());
await pumpEventQueue();
// Force a second load and fail it.
polled.pause();
polled.resume();
await pumpEventQueue();
completers[1].completeError(connectionError());
await pumpEventQueue();
expect(polled.value, 1, reason: 'keeps the last good value');
expect(polled.freshness, PolledFreshness.stale);
expect(polled.value, 1, reason: 'keeps the last good value');
expect(polled.freshness, PolledFreshness.stale);
await Future<void>.delayed(const Duration(milliseconds: 1200));
expect(polled.freshness, PolledFreshness.error);
});
await Future<void>.delayed(const Duration(milliseconds: 1200));
expect(polled.freshness, PolledFreshness.error);
},
);
test('effectiveFreshness downgrades error to stale while offline', () async {
final polled = makePolled(staleErrorAfter: const Duration(milliseconds: 1));