Display unknown values as a dash and centralise repeated literals

Backend: notifications now show a plain "-" for an absent name, vendor, or
device type (was empty string / "(unknown)" / "Unknown"), via a single
UNKNOWN_PLACEHOLDER constant.

Frontend:
- Empty/unknown values render as an em dash everywhere, centralised in a new
  Placeholders.emptyValue constant (replaces inline '—' and '(unknown)').
- Route paths moved to a new Routes class, used by the router and every
  navigation call site.
- Device event type modelled as a DeviceEventType enum mirroring the backend
  (NewDevice/DeviceSeen) instead of bare string comparisons.
- Hardcoded EdgeInsets/SizedBox spacing replaced with existing Insets tokens.

Tests and formatting updated; all backend and frontend tests pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
rzuasti
2026-06-06 16:07:05 -04:00
co-authored by Claude Opus 4.8
parent cf8979f63d
commit a51b9c06dc
32 changed files with 295 additions and 180 deletions
@@ -6,6 +6,8 @@ import '../utils/backend_reachability.dart';
import '../utils/periodic_rebuild.dart';
import '../utils/polled_value.dart';
import 'polled_stale_indicator.dart';
import '../theme/dimens.dart';
import '../routes.dart';
typedef ScannerStatus = ({Color color, String label, List<String> sublabels});
@@ -65,7 +67,7 @@ class _ScannerStatusCardState<T> extends State<ScannerStatusCard<T>>
if (freshness == PolledFreshness.initialLoading) {
return const Card(
child: Padding(
padding: EdgeInsets.all(16),
padding: EdgeInsets.all(Insets.lg),
child: Center(child: CircularProgressIndicator()),
),
);
@@ -78,13 +80,13 @@ class _ScannerStatusCardState<T> extends State<ScannerStatusCard<T>>
return Card(
clipBehavior: Clip.antiAlias,
child: InkWell(
onTap: () => context.go('/status'),
onTap: () => context.go(Routes.status),
child: Padding(
padding: const EdgeInsets.all(16),
padding: const EdgeInsets.all(Insets.lg),
child: Row(
children: [
Icon(Icons.circle, color: status.color, size: 14),
const SizedBox(width: 12),
const SizedBox(width: Insets.md),
Expanded(
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,